Opened on 01/26/2015 at 08:46:28 AM
Closed on 01/27/2015 at 10:52:34 AM
Last modified on 01/27/2015 at 11:28:47 AM
#1867 closed defect (fixed)
"Block element" dialog doesn't show if top level frame is a frameset
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1870 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
How to reproduce
- Go to http://thewml.org/example/demo/
- Click the ABP icon
- Choose "Block element"
- Click the only image on the page
Observed behaviour
The image gets highlighted but the dialog doesn't show up. That is because it is injected as <iframe> into document.body in the top-level frame. However, the top level-frame is a frameset, hence document.body is a <frameset> element which cannot have <iframe> child elements.
Expected behaviour
The dialog should show up, when an element to be blocked is selected.
Attachments (0)
Change History (4)
comment:1 Changed on 01/26/2015 at 10:14:51 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/26/2015 at 10:22:42 AM by sebastian
- Blocking 1870 added
comment:3 Changed on 01/27/2015 at 10:52:34 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 01/27/2015 at 11:28:47 AM by sebastian
- Summary changed from "Block elment" dialog doesn't show if top level frame is a frameset to "Block element" dialog doesn't show if top level frame is a frameset
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/04f28215ac4f