Opened on 03/22/2014 at 09:11:48 AM

Closed on 04/15/2014 at 09:17:58 AM

Last modified on 04/15/2014 at 09:22:45 AM

#192 closed change (fixed)

Clean up from #153

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #189 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4831974724206592/
​http://codereview.adblockplus.org/5349448087502848/

Description

Background

Due to changes in #153 our defaults/patterns.ini file is no longer being used. Also, IO.readFromFile() and IO.writeToFile() have an unused decode/encode parameter.

What to change

Remove the unused file and parameters. The API changes need to be considered in #189.

Attachments (0)

Change History (5)

comment:1 Changed on 04/14/2014 at 06:57:31 AM by trev

  • Owner set to trev
  • Status changed from new to assigned

comment:2 Changed on 04/14/2014 at 06:57:54 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:3 Changed on 04/14/2014 at 10:15:58 AM by trev

  • Blocking 189 added

comment:4 Changed on 04/15/2014 at 09:17:58 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed:

​https://hg.adblockplus.org/adblockplus/rev/c94bd1e38d2a
​https://hg.adblockplus.org/adblockplustests/rev/f994efd869f7

comment:5 Changed on 04/15/2014 at 09:22:45 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.