Opened on 03/04/2015 at 07:49:37 PM
Closed on 03/04/2015 at 10:00:43 PM
#2086 closed change (fixed)
Update adblockplusui dependency to revision 457cd7815a8a
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): |
http://codereview.adblockplus.org/4653992831352832/ |
||
Description (last modified by trev)
Background
This dependency update will import two changes:
- #2072 changed the name of the ABP icon used on the first-run page and made sure icons/detailed/abp-128.png will be used as fallback.
- #2067 changed the way text locale is determined on various pages.
What to change
In addition to updating the dependency, the name of the icon imported for the first-run page should be changed from abp-icon-big.png to abp-128.png. It should replace the currently existing icons/detailed/abp-128.png icon. Also, Icon.png in the Safari build should be mapped to that icon as well.
Hints for testers
The ABP logo should still be visible on the first-run page, and the icon on installation in Chrome and Safari should be correct. Also, text direction should still switch to right-to-left for languages like Arabic on the first-run page, options page, block element dialog and in the icon bubble.
Attachments (0)
Change History (6)
comment:1 Changed on 03/04/2015 at 07:57:50 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 03/04/2015 at 09:16:22 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 03/04/2015 at 09:31:13 PM by trev
- Description modified (diff)
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening, the mapping for Icon.png in Safari needs to be updated as well.
comment:5 Changed on 03/04/2015 at 09:32:33 PM by trev
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:6 Changed on 03/04/2015 at 10:00:43 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Fixed: https://hg.adblockplus.org/adblockpluschrome/rev/9a587a17bd87