Opened on 04/22/2015 at 12:18:19 PM

Closed on 12/11/2015 at 11:01:34 AM

Last modified on 01/19/2016 at 11:18:29 AM

#2394 closed change (fixed)

Update unit tests for CSS property filters

Reported by: trev Assignee: greiner
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: #2389 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29324604/

Description

Background

#2390, #2392, #2393 introduce significant changes to the filter handling. These need to be tested.

What to change

Update the following unit tests to consider CSS property filters:

  • domainRestrictions.js
  • filterClasses.js
  • filterListener.js
  • filterStorage_readwrite.js

Attachments (0)

Change History (5)

comment:1 Changed on 04/27/2015 at 02:01:41 PM by trev

  • Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox

comment:2 Changed on 04/27/2015 at 02:09:11 PM by greiner

  • Owner set to greiner

comment:3 Changed on 08/25/2015 at 04:12:42 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Tester set to Unknown

comment:4 Changed on 12/11/2015 at 11:01:34 AM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockplustests/rev/2fa49573d6c1

comment:5 Changed on 01/19/2016 at 11:18:29 AM by trev

  • Component changed from Adblock-Plus-for-Firefox to Extensions-for-Adblock-Plus

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.