Opened on 05/08/2015 at 09:08:19 AM

Closed on 05/08/2015 at 04:21:41 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2477 closed defect (fixed)

Adblocking settings are missing on tablets

Reported by: fhd Assignee: fhd
Priority: P1 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4883633424826368/

Description

Environment

Adblock Browser for Android revision 989a6e356d4a on a Nexus 9 running Android 5.0.2. This issue only appears on tablets.

How to reproduce

  1. Open the settings (from the hamburger menu)

Observed behaviour

There is no item called Adblocking on the left side.

Expected behaviour

There should be an item called Adblocking leading to the adblocking settings activity on the left side.

Attachments (0)

Change History (7)

comment:1 Changed on 05/08/2015 at 09:25:05 AM by fhd

Pretty sure this is a regression introduced by our upstream merge (#2352).

comment:2 Changed on 05/08/2015 at 03:27:27 PM by fhd

  • Owner set to fhd

comment:3 Changed on 05/08/2015 at 04:16:56 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/08/2015 at 04:21:41 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:6 Changed on 05/22/2015 at 09:31:58 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/5402b7899a68

comment:7 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.