Opened on 05/08/2015 at 09:18:09 AM

Closed on 05/11/2015 at 05:19:27 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2478 closed change (fixed)

Disable crash reporting

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: #2490 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5127392146227200/

Description

Background

Our upstream merge (#2352) has apparently added a crash reporter, that'll send this data to Mozilla servers. We don't want this for now.

What to change

  1. Ensure the crash reporter is not activated automatically (currently it's opt-out)
  2. Hide or remove the Crash Reporter setting under Settings->Adblock Browser->Data choices.

Attachments (0)

Change History (9)

comment:1 Changed on 05/08/2015 at 02:55:39 PM by rjeschke

  • Owner set to rjeschke

comment:2 Changed on 05/08/2015 at 03:44:47 PM by rjeschke

The solution is a build configuration switch:

Add

ac_add_options --disable-crashreporter

to mozconfig and it's gone.

comment:3 Changed on 05/08/2015 at 04:27:30 PM by rjeschke

We can probably add a line to the README, pointing to this important change. Will put up a review for this.

Next step is: creating a follow up issue to investigate if there's another way of disabling this.

comment:4 Changed on 05/08/2015 at 04:57:47 PM by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 05/11/2015 at 12:05:03 PM by rjeschke

  • Blocking 2490 added

comment:6 Changed on 05/11/2015 at 05:19:27 PM by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:8 Changed on 05/26/2015 at 03:19:30 PM by fhd

comment:9 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rjeschke.
 
Note: See TracTickets for help on using tickets.