Opened on 05/14/2015 at 03:28:38 PM
Closed on 07/05/2017 at 08:51:15 AM
#2520 closed change (fixed)
Enable extension compatibility checking again
| Reported by: | fhd | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | #2483 | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Background
We've disabled extension compatibility checking in Adblock Browser, since it used the same app ID as Firefox, but a different (lower) version. Once #2483 is done, it will have its own app ID, and we can enable compatibility checking again.
What to change
Revert commit e278fae063ee.
Hints for Testers
This can be tested together with #4765 . With compatibility check enabled, it means that it will check if the ABP plugin is compatible with the ABB MOZ_APP_ID, which is55aba3ac-94d3-41a8-9e25-5c21fe874539 (ABP defines the compatible IDs here) and with the ABB app version, which is 1.1.1 (ABP defines the compatible versions here. So basically this issue can be verified by the fact that the ABP plugin is working after re-enabling compatibility check.
Attachments (0)
Change History (14)
comment:1 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:2 Changed on 05/28/2015 at 09:35:34 AM by Mailkov
comment:3 Changed on 05/30/2015 at 11:14:43 AM by Mailkov
comment:4 Changed on 06/02/2015 at 12:55:46 PM by rjeschke
- Owner set to Mailkov
comment:5 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
See #2673
comment:6 Changed on 07/07/2015 at 10:52:35 AM by Mailkov
Please! can you unassign me?
After the discussion with rjeschke ...
I think I'm underestimated so there are no conditions for work!
comment:7 Changed on 05/27/2016 at 09:23:37 AM by diegocarloslima
- Owner changed from Mailkov to diegocarloslima
- Tester set to Unknown
comment:8 Changed on 05/27/2016 at 09:27:25 AM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 11/09/2016 at 05:33:17 PM by abpbot
A commit referencing this issue has landed:
Issue 2520 - Enable extension compatibility checking again
comment:10 Changed on 11/09/2016 at 05:34:19 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 06/19/2017 at 07:44:48 AM by scheer
- Tester changed from Unknown to Scheer
Could we add some hints for testers here please?
Thanks
comment:12 Changed on 06/20/2017 at 07:20:13 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
comment:13 Changed on 06/30/2017 at 08:09:13 PM by diegocarloslima
- Description modified (diff)
comment:14 Changed on 07/05/2017 at 08:51:15 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- The ABP plugin works after re-enabling the compatibility check.
adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
I would like to work on this... Can you assign it to me?