Opened on 06/09/2015 at 02:32:46 PM
Closed on 11/11/2015 at 12:40:12 PM
#2668 closed change (fixed)
Use new subscription types in new options page
| Reported by: | saroyanm | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | fhd, greiner | Blocked By: | #2822 |
| Blocking: | #2802, #2821 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
In #2822 we will add new subscription types to sitescripts. This allows us to distinguish between certain types of subscriptions which we can use to map them to specific features that we want to expose in the new options page.
What to change
- Remove the "popular" attribute from subscriptions.xml that was introduced in #1526
- Add "type" attribute to subscriptions.xml and update it according to #2825
- Remove the "isAdsType" and "isPopular" properties and instead check for the subscription type
- Add texts for the feature names (preferably texts should not be duplicated in firstRun.json and options.json)
- anti-adblock: Hide Adblock Warning Messages
- malware: Block Malware
- privacy: Disable Tracking
- social: Remove Social Media Buttons
- Account for future additions of a short description (used in "Blocking lists" section) and a long description (used in subscription tooltip for the "More blocking options" section)
- Instead of using the value of the "specialization" attribute from subscriptions.xml as the feature title, use the newly added texts
Notes for dependency update
This change introduces strings that are shared between first-run page and options page. Therefore common.json needs to be imported to avoid a 404 error in the console when retrieving the translations.
Attachments (0)
Change History (12)
comment:1 Changed on 06/09/2015 at 02:34:25 PM by saroyanm
- Cc greiner added
comment:2 Changed on 06/09/2015 at 03:43:34 PM by greiner
- Priority changed from Unknown to P2
comment:3 Changed on 06/22/2015 at 12:00:14 PM by saroyanm
- Blocking 2706 added; 1524 removed
comment:4 Changed on 07/17/2015 at 01:32:55 PM by greiner
- Description modified (diff)
- Tester set to Unknown
comment:5 Changed on 07/17/2015 at 05:37:58 PM by greiner
- Blocking 2802 added
comment:6 Changed on 07/27/2015 at 04:45:44 PM by greiner
- Blocked By 2822 added
- Blocking 2821 added; 2706 removed
- Description modified (diff)
- Summary changed from Localize recommended subscriptions [adblockplusui] to Use new subscription types in new options page
comment:8 Changed on 09/02/2015 at 04:19:55 PM by greiner
- Ready set
comment:9 Changed on 09/23/2015 at 03:25:18 PM by greiner
- Owner set to greiner
comment:10 Changed on 09/25/2015 at 02:35:00 PM by greiner
- Description modified (diff)
comment:11 Changed on 09/25/2015 at 03:43:52 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:12 Changed on 11/11/2015 at 12:40:12 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Please note that the description is vague intentionally, we should fix it in near future, but this will help us to keep tracking on that existing issue.
So definitely not ready yet.