Enable CrowdIn translations for adblockplusui

[greiner]

Background

Since we split off the first-run page from adblockplus and created the adblockplusui repository there has no longer been any synchronization of translations with CrowdIn. This means that there's no way for volunteers to contribute their translations.

Unlike adblockplus and adblockpluschrome, however, adblockplusui doesn't have a release process so it would make sense to integrate the translation synchronization with the existing release build tools of the versions that depend on it to ensure that the strings are always up-to-date when doing a product release.

What to change

• Create new CrowdIn project for adblockplusui strings
• Extend build.py and localeTools.py to synchronize adblockplusui strings with the newly created project whenever a release is happening for any of the platforms dependent on adblockplusui

[fhd]

For the record, if I understand things correctly, we've done the same thing in Adblock Browser for Android, albeit a bit hacky. Here's the script: ​https://hg.adblockplus.org/adblockbrowser/file/6ca822ca5b23/translations.py

Would be great if we can turn this into a minimal script that just invokes buildtools there as well.

[kzar]

The first review only covers supporting Crowdin synchronisation for the adblockplusui repository.

If we really want to make the synchronisation happen automatically at the time of an adblockpluschrome / adblockplus release it will require further changes. I would argue that it is probably a bad idea however. I think it would make more sense to add steps to the release checklists to ensure that the adblockplusui translations are kept up to date.

[kzar]

​https://hg.adblockplus.org/adblockplusui/rev/81e08dd9d89c

(Up to you Thomas if you consider this fixed now, or if the synchronisation has to be automatic first. See my previous comment.)

[greiner]

Replying to kzar:

Up to you Thomas if you consider this fixed now, or if the synchronisation has to be automatic first. See my previous comment.

As you suggested, triggering it manually and adding this step to the release checklist should already be sufficient, I think, so no need for automation if there's no added value.

[kzar]

​https://hg.adblockplus.org/adblockplusui/rev/2519171d29c9

Synchronised :)

[sebastian]

I'm not sure how the workflow should look like. But another step in the release checklist sounds like a bad idea. Though, I'm not sure how you'd automate the synchronization. But regardless of the manual vs automated argument, dependency updates nowadays usually happen independent of the release cycle. Considering adblockplusui in the release process of our products would be a step backwards. Besides making the release process even more complicated, this would also imply quite some dependencies which simply don't scale. For example code freeze of any our products would escalate to ablockplusui, with a few more products adblockplusuibeeing permanently in code freeze, just to point out one issue.

[oleksandr]

I don't think having another step in the release checklist would be the worst idea. I don't think a code freeze of any of our products would trigger a permanent code freeze for adblockplusui. The products using adblockplusui would merely freeze the reference to the specific revision of adblockplusui, with no requirement for freezing the changes to adblockplusui as I see it.