Opened on 10/08/2015 at 02:37:32 PM
Closed on 09/11/2017 at 04:20:38 PM
#3181 closed change (fixed)
Remove the language part from verification-success URL
| Reported by: | oleksandr | Assignee: | ferris |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | matze, saroyanm, oleksandr, fred | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by oleksandr)
Background
We don't have any translations for the verification success page, so it would make sense to make it language agnostic.
What to change
Change the value of successful_verification_redirect_location setting from:
https://adblockplus.org/{lang}/verification-success
to
https://adblockplus.org/verification-success
Attachments (0)
Change History (9)
comment:1 Changed on 10/08/2015 at 02:52:58 PM by matze
comment:4 Changed on 10/09/2015 at 08:14:35 AM by oleksandr
This change is just for consistency. Since we don't translate the page anyway it doesn't make sense to have {lang} as a parameter. This is really low priority too.
I have changed the URLs in the description, sorry for the confusion.
comment:5 Changed on 10/09/2015 at 08:20:16 AM by matze
- Cc oleksandr. fred added; oleksandr removed
- Priority changed from Unknown to P3
comment:6 Changed on 10/09/2015 at 08:20:51 AM by matze
- Cc oleksandr added; oleksandr. removed
comment:7 Changed on 10/09/2015 at 08:35:34 AM by saroyanm
Please see #3183, if the ticket is reasonable, then we will not need this changes, because this is a small hack which would be nice to avoid I think.
comment:8 Changed on 09/11/2017 at 04:20:26 PM by ferris
- Owner set to ferris
comment:9 Changed on 09/11/2017 at 04:20:38 PM by ferris
- Resolution set to fixed
- Status changed from new to closed
A fix for this has been deployed on the server with
Note: See
TracTickets for help on using
tickets.
How does this fit together with the "rejected" status of #2425? Also, please note that there is no */adblock-browser/verification-success page, it's */verification-success. See #2846 for more information. Cheers!