Opened on 10/22/2015 at 06:07:09 PM

Closed on 12/02/2015 at 01:19:17 PM

#3226 closed change (fixed)

Unbreak content policy unit tests

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Extensions-for-Adblock-Plus Keywords: e10s
Cc: Blocked By: #3222
Blocking: #3208 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29329739/

Description

Background

#3208 will break content policy unit tests because they rely on the same RequestNotifier functionality as blockable items.

What to change

#3222 should fix this mostly, only minor adjustments to API changes are expected.

Attachments (0)

Change History (6)

comment:1 Changed on 10/23/2015 at 05:48:15 PM by trev

  • Blocked By 3208 removed

comment:2 Changed on 10/23/2015 at 05:48:26 PM by trev

  • Blocking 3208 added

comment:3 Changed on 11/04/2015 at 11:10:07 AM by trev

  • Owner set to trev

comment:4 Changed on 11/04/2015 at 11:10:18 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/04/2015 at 03:07:03 PM by trev

  • Keywords e10s added

comment:6 Changed on 12/02/2015 at 01:19:17 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplustests/rev/5c5c9f679eef

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.