Opened on 01/19/2016 at 12:51:47 PM
Closed on 02/16/2016 at 02:20:37 PM
Last modified on 02/24/2016 at 11:17:29 AM
#3538 closed defect (fixed)
Filter listener tests fail for CSS property rules
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.7.2-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Adblock Plus 2.7.1, Firefox 46.0a1 nightly
How to reproduce
- Run filterListener unit tests.
Observed behaviour
Unit tests fail to detect CSS property rules that have been added, claiming that none have been. This is yet another fallout from bug 1202902, variable filters in cssRules.js isn't global.
Expected behaviour
Unit tests should run through correctly.
Hints for testers
This shouldn't have any visible effects in the product whatsoever. The dependency update also imported the fix for #3612 from adblockpluscore which only touches comments. Also, changes for #3654, #3618 and #2598 have been imported, these don't touch any files used in Adblock Plus for Firefox however.
Attachments (0)
Change History (4)
comment:1 Changed on 02/16/2016 at 12:40:00 PM by trev
- Owner set to trev
comment:2 Changed on 02/16/2016 at 12:40:10 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 02/16/2016 at 02:20:37 PM by trev
- Description modified (diff)
- Milestone set to Adblock-Plus-2.7.2-for-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 02/24/2016 at 11:17:29 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Marking verified as changes have not caused any adverse effects / ABP is still working as expected.
ABP 2.7.2
Firefox 38.0 / Firefox 46.0a1 (Nightly) / Ubuntu 14.04 x64
Firefox 38.0 / Firefox 43.0.1 / Firefox 46.0a1 (Nightly) / Windows 7 x64
Fixed:
https://hg.adblockplus.org/adblockpluscore/rev/4d43739579c2
https://hg.adblockplus.org/adblockplus/rev/bfb6a1db9188