Opened on 02/15/2016 at 11:12:22 AM
Closed on 01/10/2017 at 02:55:06 PM
Last modified on 04/27/2017 at 10:49:19 AM
#3653 closed change (fixed)
Modify application parameter in ABB for iOS
| Reported by: | sporz | Assignee: | fhd |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Browser-for-iOS-1.5.2 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | mario, pavelz, Kirill, fhd | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Background
We rely on application parameters sent when downloading resources like easylist.txt, etc. as basis for debugging and analyses.
AdblockBrowser for iOS currently provides application=chrome which cannot be linked to the product.
What to change
Change the query string parameter while requesting filter lists to application=adblockbrowserios
Attachments (0)
Change History (15)
comment:1 Changed on 02/15/2016 at 11:12:43 AM by sporz
- Cc Kirill added
comment:2 Changed on 02/15/2016 at 03:37:45 PM by sporz
- Cc pavelz added; pavel@kitt.com removed
comment:3 Changed on 02/15/2016 at 03:38:44 PM by sporz
- Sensitive unset
comment:4 Changed on 02/16/2016 at 03:27:09 PM by fhd
- Owner set to fhd
- Priority changed from Unknown to P3
- Ready set
comment:5 Changed on 02/23/2016 at 02:55:50 PM by fhd
comment:6 Changed on 02/23/2016 at 04:31:18 PM by sporz
From a data perspective, application now and applicationVersion later sounds much better than both later =D
comment:7 Changed on 02/23/2016 at 04:40:15 PM by pavelz
platform depends on what other values are you used to in there. Does it say Firefox or Android for your Android browser?
comment:8 Changed on 02/23/2016 at 04:50:31 PM by sporz
On adblockbrowser for android it says platform=gecko, platformVersion=40.0.
comment:9 Changed on 02/23/2016 at 04:56:36 PM by pavelz
That would interpolate to platform kitt. The fact that it's iOS is inseparable. Then there is a question of how you determine the iOS version, but you don't know that on Android either, do you? Are you even interested in the underlying OS version?
comment:10 Changed on 04/01/2016 at 12:31:49 PM by pavelz
- Cc fhd added
@fhd a proposal: you declare a property/setter on AdblockPlusApi in api.js and we set/call it for you with a version string as soon as the background script is loaded
comment:11 Changed on 05/11/2016 at 02:20:12 PM by mario
- Priority changed from P3 to P4
comment:12 Changed on 10/04/2016 at 04:01:28 PM by pavelz
- Keywords blocked added
comment:13 Changed on 01/10/2017 at 02:55:06 PM by mario
- Description modified (diff)
- Keywords blocked removed
- Resolution set to fixed
- Status changed from new to closed
- Summary changed from Modify application and applicationVersion parameters in ABB for iOS to Modify application parameter in ABB for iOS
I'm closing this issue, as the application parameter has already landed. Changed the description to reflect this scope. As suggested by fhd, however, I've filed follow-up issues to work on the remaining discussed parameters:
comment:14 Changed on 02/08/2017 at 01:05:43 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:15 Changed on 04/27/2017 at 10:49:19 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- The query string parameter while requesting filter lists now shows as application=adblockbrowserios
Recent fetch shows:
GET /exceptionrules.txt?addonName=adblockplusadblockbrowserios&addonVersion=1.12.4.1671&application=adblockbrowserios&applicationVersion=0&platform=chromium&platformVersion=0&lastVersion=0&downloadCount=0 HTTP/1.1
ABB iOS 1.5.2 (Core 1.5.2)
iPhone 6S Plus
iOS 10.2
Here's a start: https://bitbucket.org/adblockplus/adblockplusadblockbrowserios/commits/8d9f40c87ce1dad05844f69de36f933208d59f03
This will only set application correctly since we have no mechanism for determining applicationVersion yet. But I suppose it'll be good enough for now?
If so, we need a follow-up issue for setting it properly. And we should think about platform and platformVersion while at it. Does it make more sense to have iOS or Kitt as the platform?