Opened on 03/10/2016 at 02:51:56 PM
Closed on 03/11/2016 at 04:00:42 PM
Last modified on 04/20/2016 at 02:14:47 AM
#3771 closed change (fixed)
Update adblockpluscore dependency and adapt filter validation
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
With #3659 InvalidFilter.reason is no longer a translated string but a string ID. The calling code needs to be adapted accordingly. Also we need to update the adblockplus dependency at the same time to import the related strings.
Also with #3660 support for some legacy filter lists have been removed. This however doesn't require any changes to the code here.
Other changes in this dependency update aren't visible in the Chrome and Safari builds.
What to change
- Update the adblockpluscore dependency to 3b518ca1bfcc.
- Update the adblockplus dependency to 1e8c64115e5b and import related strings.
- Adapt existing code for InvalidFilter.reason being a string ID.
Hints for testers
Make sure that filter validation as performed on the options page and in the "Block element" dialog still works as it did before. So when you enter valid filters, these should be saved. If the filter isn't valid (e.g. foo$unkown-option) this should bring up an error message instead.
Attachments (0)
Change History (6)
comment:1 Changed on 03/10/2016 at 02:54:54 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/11/2016 at 03:59:29 PM by abpbot
comment:5 Changed on 03/11/2016 at 04:00:42 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/20/2016 at 02:14:47 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
ABP 1.11.0.1597
Chrome 32 / 44 / 48 / Windows 8
Opera 24 / 28 / Windows 8
Chrome 44 / Ubuntu 14.04
Safari 6 / 8 / 9 / OS X 10.8 / 10.10 / 10.11
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/ddbed2e20300