Opened on 03/18/2016 at 12:20:30 PM
Closed on 03/21/2016 at 03:35:31 PM
Last modified on 04/22/2016 at 02:47:44 PM
#3835 closed change (fixed)
Update dependency on adblockpluscore to revision 2d4888611240
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.7.3-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | #3836 | |
| Blocking: | #2401 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
We need to import a change to the CSS property rules content script that was implemented in #2401, otherwise this script won't work in Firefox. This will also import changes from #3659, #3660 and #3836.
What to change
Code accessing InvalidFilter.reason has to be adapted, this will be a string ID now. The strings filter_unknown_option and filter_invalid_regexp have been added already.
Also, code accessing Subscription.title has to deal with empty titles now. Also, DownloadableSubscription.upgradeRequired is gone, code using this should do a version comparison itself.
Attachments (0)
Change History (6)
comment:1 Changed on 03/18/2016 at 12:29:02 PM by trev
- Blocked By 3836 added
comment:2 Changed on 03/18/2016 at 02:18:48 PM by trev
- Description modified (diff)
- Summary changed from Update dependency on adblockpluscore to revision 9dbbcdc4ff57 to Update dependency on adblockpluscore to revision 2d4888611240
comment:3 Changed on 03/18/2016 at 02:54:06 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/21/2016 at 03:34:27 PM by abpbot
comment:5 Changed on 03/21/2016 at 03:35:31 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/22/2016 at 02:47:44 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Verifying this now the related tickets have been verified themselves.
ABP 2.7.2.4166
Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/c5a6f9959198