Opened on 06/08/2016 at 02:17:43 PM
Closed on 06/29/2016 at 05:01:14 PM
Last modified on 09/07/2016 at 03:22:48 PM
#4139 closed change (fixed)
Don't save element hiding filters on disk
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | #4140, #4170, #4203 | |
| Blocking: | #521, #4162 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29345667/ |
||
Description
Background
Bug 1187099 is back on Mac OS X and breaks element hiding functionality in Firefox nightly builds. Also, we want to become more flexible and use different stylesheets depending on the website (see also #524).
What to change
Don't save elemhide.css to disk. Instead, serve that data dynamically via about:abp-elemhidehit protocol we implement already.
Attachments (0)
Change History (13)
comment:1 Changed on 06/08/2016 at 02:25:36 PM by trev
- Blocked By 4140 added
comment:2 Changed on 06/08/2016 at 08:40:16 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/17/2016 at 12:16:03 AM by trev
- Blocking 4162 added
comment:4 Changed on 06/17/2016 at 10:08:50 AM by trev
- Blocking 521 added
comment:5 Changed on 06/17/2016 at 10:44:39 PM by abpbot
comment:6 Changed on 06/17/2016 at 10:47:12 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 06/29/2016 at 04:05:13 PM by trev
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening, the patch here had a stupid bug which caused a memory leak.
comment:8 Changed on 06/29/2016 at 04:07:11 PM by trev
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:9 Changed on 06/29/2016 at 05:00:44 PM by abpbot
A commit referencing this issue has landed:
Issue 4139 - Fixed memory leak due to bug in previous patch
comment:10 Changed on 06/29/2016 at 05:01:14 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Resolving as fixed again.
comment:11 Changed on 06/29/2016 at 05:06:10 PM by trev
- Blocked By 4170 added
comment:12 Changed on 06/29/2016 at 07:07:00 PM by trev
- Blocked By 4203 added
comment:13 Changed on 09/07/2016 at 03:22:48 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done, elemhide.css is no longer saved to disk.
ABP 2.7.3.4198-beta
Nightly 51.0a1 / Windows 7 / OS X 10.10
Firefox 48 / Windows 7 / OS X 10.10
A commit referencing this issue has landed:
Issue 4139 - Don't save element hiding filters on disk