Opened on 06/08/2016 at 02:25:36 PM

Closed on 06/17/2016 at 12:06:47 AM

#4140 closed change (fixed)

Remove Firefox-specific element hiding functionality

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4139 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345663/

Description (last modified by trev)

Background

elemhide module will currently write data to elemhide.css and register an user stylesheet pointing to it. This functionality is Firefox-specific and we want to remove parts of it in #4139 anyway.

What to change

Remove ElemHide.init, ElemHide.apply and ElemHide.unapply methods. Instead, ElemHide should call FilterNotifier.emit("elemhideupdate") on changes.

Attachments (0)

Change History (4)

comment:1 Changed on 06/08/2016 at 02:31:31 PM by trev

  • Description modified (diff)

comment:2 Changed on 06/08/2016 at 08:24:48 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 06/17/2016 at 12:03:06 AM by abpbot

A commit referencing this issue has landed:
​Issue 4140 - Remove Firefox-specific element hiding functionality

comment:4 Changed on 06/17/2016 at 12:06:47 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.