Opened on 06/23/2016 at 11:54:06 AM
Closed on 09/08/2017 at 09:18:54 AM
#4188 closed change (fixed)
Update libadblockplus-android to use the latest libadblockplus
| Reported by: | asmirnov | Assignee: | asmirnov |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | rjeschke, sergz | Blocked By: | #4194 |
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by asmirnov)
Currently libadblockplus-android (https://hg.adblockplus.org/libadblockplus-android/rev/23e85c987663) uses libadblockplus-binaries revision aafebe7adfee1691d6dd8656f8c8628fa5ee1209 built for not the latest libadblockplus revision.
dependencies file:
libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg:aafebe7adfee1691d6dd8656f8c8628fa5ee1209 git:84620d7a1c7bc71d3af864384478160a864de698
Here is the list of latest changes imported:
#3594, #4612 and all the libadblockplus issues created after Dec 5, 2015 (lots of)
aafebe7adfee1691d6dd8656f8c8628fa5ee1209 binaries relate to libadblockplus revision aea52ce09b97 which is 6-months-old.
libadblockplus-android should be changed to be compiled again the latest libadblockplus revision 031f392dda1. or even newer if created.
modify 'libadblockplus-binaries' and 'libadblockplus-android' repositories (to be synced)
Attachments (0)
Change History (11)
comment:3 Changed on 06/23/2016 at 01:13:43 PM by asmirnov
- Owner set to asmirnov
comment:4 Changed on 06/24/2016 at 03:04:33 PM by asmirnov
- Blocked By 4194 added
comment:5 Changed on 06/27/2016 at 06:54:16 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 in reply to: ↑ 6 Changed on 12/05/2016 at 02:03:33 PM by asmirnov
Replying to fhd:
Could you list any libadblockplus issues that have landed in the mean time and think about whether we need to change libadblockplus-android for that? Here's an example of a dependency update issue: #2732.
Updated issue description.
It seems that #4612 is enough to update libadblockplus-android at least.
comment:9 Changed on 12/05/2016 at 05:51:03 PM by abpbot
A commit referencing this issue has landed:
Issue 4188 - Update libadblockplus-android to use the latest libadblockplus
comment:10 Changed on 12/20/2016 at 11:20:54 AM by abpbot
A commit referencing this issue has landed:
Issue 4188 - Update libadblockplus-android to use the latest libadblockplus
comment:11 Changed on 09/08/2017 at 09:18:54 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
It seems not relevant already
Could you list any libadblockplus issues that have landed in the mean time and think about whether we need to change libadblockplus-android for that? Here's an example of a dependency update issue: #2732.