Opened on 08/22/2016 at 02:26:03 PM
Closed on 09/26/2016 at 04:22:08 PM
Last modified on 09/26/2016 at 04:27:10 PM
#4348 closed change (fixed)
Only show adware page notification if visited from the extension
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | juliandoucette, philll, jeen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
With #3802 we have created an adware page which also show a warning notification, which is not true for the users who are not being linked to the page from the extension notification.
What to change
Make the notification message on the page visible only in case users are visiting the page from the extension's notification, for that we need to have a flag in the URL (query string): ?warning=true.
Attachments (0)
Change History (9)
comment:1 Changed on 08/22/2016 at 03:34:24 PM by saroyanm
- Owner set to saroyanm
comment:2 Changed on 08/22/2016 at 03:37:27 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/26/2016 at 03:13:32 PM by saroyanm
comment:5 Changed on 09/26/2016 at 04:21:43 PM by abpbot
A commit referencing this issue has landed:
Issue 4348 - control adware page warning through url parameter
comment:6 Changed on 09/26/2016 at 04:22:08 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 follow-up: ↓ 8 Changed on 09/26/2016 at 04:23:47 PM by juliandoucette
- Cc jeen added
Note: Jeen wanted to know if we link to this page anywhere because it affects her priorities.
comment:8 in reply to: ↑ 7 Changed on 09/26/2016 at 04:25:40 PM by saroyanm
Replying to juliandoucette:
Note: Jeen wanted to know if we link to this page anywhere because it affects her priorities.
We currently only linking from the social media post, but not extensions.
comment:9 Changed on 09/26/2016 at 04:27:10 PM by juliandoucette
@Jeen Google does index public Social Media posts and may index this page as a result (even though it appears they have not yet).
@Phill, the implementation is ready to launch, can you please let me know if we already linking to this page from the extension ?