Opened on 11/01/2016 at 08:59:19 AM

Closed on 11/22/2016 at 02:34:09 PM

Last modified on 05/22/2017 at 12:12:48 PM

#4592 closed change (fixed)

Adapt messaging code for the new element hiding emulation filters

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By: #4394
Blocking: #4658, #4659, #4659 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361722/

Description

Background

#4394 replaces CSS property filters with the more generic element hiding emulation filters.

What to change

The messaging code in the UI repository needs to be adapted to work with the new element hiding emulation filters.

Attachments (0)

Change History (8)

comment:1 Changed on 11/03/2016 at 06:25:47 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/22/2016 at 11:07:32 AM by fhd

  • Blocking 4658 added

comment:3 Changed on 11/22/2016 at 11:18:11 AM by fhd

  • Blocked By 4394 added
  • Blocking 4659 added; 4394 removed

comment:4 Changed on 11/22/2016 at 11:21:55 AM by fhd

  • Summary changed from Adapt for element hiding emulation filters to Adapt messaging code for the new element hiding emulation filters

comment:5 Changed on 11/22/2016 at 11:23:36 AM by fhd

  • Blocking

comment:6 Changed on 11/22/2016 at 02:33:21 PM by abpbot

comment:7 Changed on 11/22/2016 at 02:34:09 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 05/22/2017 at 12:12:48 PM by Ross

Tested this change as part of #4658 and it appears to be working okay.

(Leaving ticket open until Chrome changes).

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Beta (54.0b2)
Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
 
Note: See TracTickets for help on using tickets.