Opened on 11/22/2016 at 11:09:41 AM

Closed on 12/20/2016 at 09:13:25 PM

#4659 closed change (fixed)

Incorporate element hiding emulation filters

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Plus-1.13-for-Chrome-Opera
Module: Platform Keywords:
Cc: kzar Blocked By: #4394, #4592, #4658
Blocking: #4715 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29367475/

Description (last modified by fhd)

Background

#4394 replaces CSS property filters with the more generic element hiding emulation filters, #4592 adapts the adblockplusui repository and #4658 the adblockplus repository.

This dependency update is also pulling in the following changes:

  • #4684, which makes { and } work in property selectors
  • #4644, which adds request filtering to our devtools panel (still needs a platform change though)

What to change

  1. Update the adblockpluscore dependency to revision b1e70036624f, the adblockplusui dependency to revision 7fe282d20303 and the adblockplus dependency to revision c8ec667756d3.
  2. Adapt the platform code to work with the new filter class.

Attachments (0)

Change History (12)

comment:1 Changed on 11/22/2016 at 11:14:51 AM by fhd

  • Summary changed from Adapt for element hiding emulation filters to Incorporate element hiding emulation filters

comment:2 Changed on 11/22/2016 at 11:19:27 AM by fhd

  • Blocked By 4394 added

comment:3 Changed on 11/22/2016 at 11:23:36 AM by fhd

  • Blocked By 4592 added

comment:4 Changed on 11/22/2016 at 03:17:57 PM by fhd

  • Description modified (diff)

comment:5 Changed on 12/07/2016 at 02:49:23 PM by wspee

  • Blocking 4715 added

comment:6 Changed on 12/13/2016 at 07:50:53 PM by fhd

  • Description modified (diff)

comment:7 Changed on 12/13/2016 at 09:27:39 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed on 12/20/2016 at 02:25:22 PM by fhd

  • Description modified (diff)

comment:9 Changed on 12/20/2016 at 09:11:22 PM by abpbot

A commit referencing this issue has landed:
​Issue 4659 - Incorporate element hiding emulation filters

comment:10 Changed on 12/20/2016 at 09:12:23 PM by fhd

  • Description modified (diff)

comment:11 Changed on 12/20/2016 at 09:12:59 PM by fhd

  • Description modified (diff)

comment:12 Changed on 12/20/2016 at 09:13:25 PM by fhd

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.