Opened on 11/22/2016 at 11:07:32 AM
Closed on 12/13/2016 at 07:37:07 PM
Last modified on 05/22/2017 at 12:10:46 PM
#4658 closed change (fixed)
Incorporate element hiding emulation filters
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.9-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, kzar | Blocked By: | #4394, #4592 |
| Blocking: | #4659 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by fhd)
Background
#4394 replaces CSS property filters with the more generic element hiding emulation filters, #4592 adapts the adblockplusui repository for that. Once these changes have landed, we can update ABP for Firefox to work with the new filter class.
This dependency update is also pulling in #4684, which makes { and } work in property selectors.
What to change
- Update the adblockpluscore dependency to revision b1e70036624f and the adblockplusui dependency to revision 4286b54830e5.
- Adapt the ABP for Firefox code to work with the new filter class.
Attachments (0)
Change History (9)
comment:1 Changed on 11/22/2016 at 11:09:41 AM by fhd
- Blocking 4659 added
comment:2 Changed on 11/22/2016 at 11:16:16 AM by fhd
- Summary changed from Adapt for element hiding emulation filters to Incorporate element hiding emulation filters
comment:3 Changed on 11/22/2016 at 02:35:45 PM by fhd
- Blocking 3143 removed
comment:5 Changed on 11/24/2016 at 11:33:44 AM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 12/13/2016 at 07:32:50 PM by abpbot
comment:8 Changed on 12/13/2016 at 07:37:07 PM by fhd
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 05/22/2017 at 12:10:46 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done/implemented. Appears to work okay (CSS property filters are working).
The only issue I noticed is that hit counters for these filters are not updated: #5256.
ABP 2.8.2.4246-beta
Firefox 51 / 53 / Beta (54.0b2)
Windows 7
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4658 - Incorporate element hiding emulation filters