Opened on 05/15/2014 at 11:45:39 AM
Closed on 11/21/2014 at 10:34:57 AM
#491 closed defect (fixed)
Element hiding breaks if user adds a custom filter with invalid CSS selector
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.8-for-Chrome-Opera-Safari |
| Module: | User-Interface | Keywords: | |
| Cc: | philll, trev, smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
Chrome, Opera and Safari
How to reproduce
- Go to Options -> Add your own filters
- Add an element hiding filter using an invalid CSS selector, e.g. ##div[attr="foo']
- Open any website
Observed behaviour
Ads are not removed by element hiding. You also see following error in the JavaScript console: Failed to execute 'insertRule' on 'CSSStyleSheet': Failed to parse the rule.
Expected behaviour
The options UI should reject to save filters that lead to errors when applied.
Attachments (0)
Change History (14)
comment:1 Changed on 05/15/2014 at 12:14:09 PM by mapx
- Cc smultron45@gmail.com added
comment:2 Changed on 05/15/2014 at 12:23:41 PM by sebastian
comment:3 Changed on 05/15/2014 at 03:09:40 PM by sebastian
- Ready set
comment:4 Changed on 05/25/2014 at 04:14:07 AM by seannaM
I've put some work into this and I'm making good progress. Can I be assigned the issue?
comment:6 Changed on 05/31/2014 at 10:24:33 PM by seannaM
I believe I have a working solution. You can see my approach here:
https://github.com/evilseanbot/adblockpluschrome/tree/iss491
comment:7 Changed on 06/02/2014 at 01:57:29 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 10/22/2014 at 11:32:51 AM by sebastian
- Cc sebastian removed
comment:9 Changed on 11/18/2014 at 03:48:45 PM by sebastian
- Blocked By 1583 added
comment:10 Changed on 11/18/2014 at 03:49:05 PM by sebastian
- Blocked By 1583 removed
- Description modified (diff)
- Owner changed from seannaM to sebastian
- Platform set to Unknown
comment:11 Changed on 11/18/2014 at 03:49:20 PM by sebastian
- Blocking 1583 added
comment:12 Changed on 11/18/2014 at 03:58:18 PM by sebastian
- Review URL(s) modified (diff)
comment:13 Changed on 11/19/2014 at 01:36:22 PM by sebastian
- Blocking 1583 removed
comment:14 Changed on 11/21/2014 at 10:34:57 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
See #493 and #494 for the corresponding issues in Adblock Plus for Firefox.