Opened on 04/04/2017 at 12:21:14 PM
Closed on 04/05/2017 at 07:09:41 AM
Last modified on 04/05/2017 at 12:14:44 PM
#5097 closed defect (fixed)
Element Hiding Helper: TypeError: node is undefined
| Reported by: | Ross | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Element-Hiding-Helper-1.4 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
ABP 2.8.2
EHH 1.3.10.551-beta
Firefox 52 / Windows 7
(Also occurs when using ABP 2.8.2.4242-beta)
How to reproduce
- Start EHH element selection.
- Hover an element (any).
- Press V to view source of element hovered.
Observed behaviour
The source is displayed as expected but the following error occurs:
TypeError: node is undefined commands.js:39:1
Expected behaviour
Error not to occur.
Attachments (0)
Change History (6)
comment:1 Changed on 04/04/2017 at 05:58:45 PM by trev
comment:2 Changed on 04/04/2017 at 06:00:36 PM by trev
- Owner set to trev
- Priority changed from P3 to P1
- Ready set
comment:3 Changed on 04/04/2017 at 06:00:49 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/05/2017 at 07:09:00 AM by abpbot
A commit referencing this issue has landed:
Issue 5097, issue 5099 - Only retrieve element source from the process actually selecting
comment:5 Changed on 04/05/2017 at 07:09:41 AM by trev
- Milestone set to Element-Hiding-Helper-1.4
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/05/2017 at 12:14:44 PM by Ross
- Verified working set
Fixed. Errors no longer occur.
ABP 2.8.2
EHH 1.3.10.522-beta
Firefox 52 / Windows 7
Note: See
TracTickets for help on using
tickets.
Both this issue and #5099 are because both processes attempt to respond to the request - yet the selection is only running in one of them. I wonder why I don't see these errors but it is pretty obvious what the issue is and how to fix it.