Opened on 04/20/2017 at 08:32:45 AM
Closed on 04/20/2017 at 12:55:40 PM
#5157 closed change (fixed)
Update dependency on adblockpluscore to revision 66bcf4dca35a
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.9-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In #5059 we simplified required I/O APIs considerably, and #5153 removed some backwards compatibility considerations that would complicate the Emscripten-based implementation. We now need to import these changes into Adblock Plus for Firefox. Additional changes imported by this update:
- https://hg.adblockplus.org/adblockpluscore/rev/ef3dd3b218e9 - unit tests code, not relevant for the build.
- #5086 - $webrtc filter type being added but not used in Firefox.
What to change
Update io.js and other APIs as outlined in #5059. Test whether $webrtc will show up in filter assistant, blacklist it if necessary.
Hints for testers
This again changes how patterns.ini and automatic backups are being read and written. It has to be verified that no data loss (including metadata like filter hits) happens after an update, that both automatic and manual backups can be restored even if created with an older Adblock Plus version. Finally, "Add Adblock Plus filter rule" dialog should still work and not offer "webrtc" type in the "Apply to types" advanced section.
Attachments (0)
Change History (3)
comment:1 Changed on 04/20/2017 at 08:49:34 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/20/2017 at 12:53:55 PM by abpbot
comment:3 Changed on 04/20/2017 at 12:55:40 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 5157 - Update dependency on adblockpluscore to revision 66bcf4dca35a