Error when attempting to show notifications in Opera

[Ross]

Environment

ABP 1.13.3.1838
Opera 47 / Windows 10

How to reproduce

1. Install ABP.
2. Serve the notification.json request made after install a valid notification. -or-
3. Add a notification via console.

Observed behaviour

No notification appears and the following error appears in the background page console:

Unchecked runtime.lastError while running notifications.create: Adding buttons to notifications is not supported.
at showNotification (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/lib/adblockplus.js:1418:28)
at Object.showNext (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/lib/adblockplus.js:8816:9)
at Object._onDownloadSuccess (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/lib/adblockplus.js:8637:18)
at XMLHttpRequest.request.addEventListener.event (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/lib/adblockplus.js:4470:12)

Expected behaviour

The notification to appear and the error to not occur.

[Ross]

This is like #5354 when the anti-adblock notification should be triggered. As far as I remember, normal (non-button/question) notifications should work in Opera but do not because of this issue.

[jsonesen]

Is this a duplicate of #5354 or should they at least be linked?

[sebastian]

As Ross pointed out above, #5354 is about the chrome.notifications API not supporting buttons on Opera. This issue is about notifications that aren't even supposed to have buttons causing an error as well. This seems to be because we pass buttons to chrome.notifications.create() even if it is an empty array. But Iagree that this can be merged into #5354.