Opened on 09/06/2017 at 01:01:55 PM
Closed on 10/25/2017 at 08:47:40 AM
#5632 closed change (fixed)
Use checkboxes for toggling acceptable ads and add new label
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, juliandoucette | Blocked By: | #5869 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29578574/ |
||
Description (last modified by saroyanm)
Background
After several design iterations we finally have a final version of the new options page (See #5158).
But the section of adding Acceptable Ads in general tab is misleading, because we mentioned "Block All ads" for the option which disables acceptable ads, but we need to communicate to the user that this option disables acceptable ads.
What to change
Implement new layout of managing Acceptable Ads as specified here using current style guide.
Attachments (0)
Change History (18)
comment:1 Changed on 09/06/2017 at 01:24:55 PM by saroyanm
- Description modified (diff)
- Summary changed from New label next to the Privacy friendly acceptable ads is missing to New label next to the Privacy friendly acceptable ads and DNT link is missing
comment:2 Changed on 09/15/2017 at 04:53:20 PM by saroyanm
- Priority changed from P2 to P1
comment:3 Changed on 09/18/2017 at 10:45:17 AM by saroyanm
- Owner set to saroyanm
comment:5 Changed on 09/25/2017 at 04:01:47 PM by saroyanm
- Description modified (diff)
- Summary changed from New label next to the Privacy friendly acceptable ads and DNT link is missing to New label next to the Privacy friendly acceptable ads is missing
comment:6 Changed on 09/25/2017 at 04:02:36 PM by saroyanm
- Priority changed from P1 to P2
This is not P1 anymore as the P1 part is removed from this ticket see comment above.
comment:7 Changed on 09/27/2017 at 05:06:36 PM by saroyanm
- Blocking 5158 removed
We decided during today meeting that this shouldn't be blocker for the initial release on dev builds.
comment:8 Changed on 10/16/2017 at 10:57:40 AM by saroyanm
- Description modified (diff)
I've updated this issue description to reflect the whole layout change that also includes the "new" label, because we already launched the section without "new" label.
comment:10 Changed on 10/16/2017 at 11:01:21 AM by saroyanm
- Summary changed from New label next to the Privacy friendly acceptable ads is missing to Use checkboxes for enabling acceptable ads and add new label
comment:11 Changed on 10/16/2017 at 11:01:43 AM by saroyanm
- Summary changed from Use checkboxes for enabling acceptable ads and add new label to Use checkboxes for toggling acceptable ads and add new label
comment:12 Changed on 10/16/2017 at 12:03:38 PM by saroyanm
- Description modified (diff)
comment:13 Changed on 10/17/2017 at 10:35:06 AM by saroyanm
- Blocked By 5869 added
comment:14 Changed on 10/17/2017 at 10:36:57 AM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:15 Changed on 10/23/2017 at 11:15:35 AM by abpbot
A commit referencing this issue has landed:
Issue 5632 - Use checkboxes for toggling acceptable ads
comment:16 Changed on 10/24/2017 at 04:57:18 PM by saroyanm
- Review URL(s) modified (diff)
comment:17 Changed on 10/25/2017 at 08:47:19 AM by abpbot
A commit referencing this issue has landed:
Issue 5632 - Add 'new' label next to the Privacy Friendly Acceptable Ads
comment:18 Changed on 10/25/2017 at 08:47:40 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Missing DNT link is being handled in #5701