Opened on 09/29/2017 at 08:58:33 AM

Closed on 09/29/2017 at 02:17:00 PM

#5809 closed change (fixed)

Update adblockpluscore dependency to revision hg:5f5cea471d7e

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29559564/

Description

Background

Update the core mainly because the recent changes in the core reduces the memory usage.

The list of changes imported by this is:

Ticket Summary Component
#5797 Remove obsolete arguments from ElemHideEmulation constructor Core
#5773 Element hiding emulation filters do not work in old Chrome/Opera versions Core
#5735 Use JS Map instead of Object Core
#5728 Replace Services.vc.compare Core
#5558 Make notifications not ignore unknown targets Core
#5516 Bundle the browser tests and dependencies using webpack, adding module support Core
#5460 Add support to show a notification based on the locale of the user Core
#5459 Add support to show a notification based on the number of ads blocked Core
#5438 Listen to DOM changes to eventually reapply filters. Core
#5436 Relative selectors in :-abp-has() broken Core
#5422 Property selector matching * selector doesn't work Core
#5404 :-abp-properties() nested within :-abp-has() doesn't work if the relevant selector refers to outside nodes Core
#5395 Scrolling through Facebook feed is very laggy Core
#5339 Properly select element from pseudo-element Core
#5079 Export ElemHideEmulation and splitSelector Core


b935a0402215Noissue - Throw an error if the client code doesn't loadHubert Figuière
8a9c308bb8fbNoissue - Reorder chromium_process.js importsDave Barker
3af11978db00Noissue - Updated copyright yearWladimir Palant
e775d9190f02Noissue - Enable source map for the testsHubert Figuière
d84358f9e0c0Noissue - Added testcase to show that unknown notification targets are ignoredWinsley von Spee
adffd8564570Noissue - Refactored notification target checking (checkTarget) to make it more easily expandableWinsley von Spee
fb758f96f7bbNoissue - rename variable 'ret' to more meaningful 'filter' in lib/filterClasses.jsSergei Zabolotskikh

What to change

Adapt the code in accordance with the made changes in the core.

Attachments (0)

Change History (3)

comment:1 Changed on 09/29/2017 at 09:34:48 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/29/2017 at 02:16:10 PM by abpbot

comment:3 Changed on 09/29/2017 at 02:17:00 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
 
Note: See TracTickets for help on using tickets.