Opened on 10/09/2017 at 02:27:25 AM

Closed on 10/11/2017 at 03:39:11 PM

#5845 closed change (fixed)

Rename "gecko-webext" build target to "gecko"

Reported by: sebastian Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: tlucas Blocked By: #5751
Blocking: #5837 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29572692/

Description

Background

When we added support for Firefox/WebExtensions to buildtools we had to come up with a new name for the build target (given with -t option), since gecko was already used to build legacy Gecko extensions. However, support for legacy Gecko extension is now removed from buildtools (#5751).

What to change

Rename the gecko-webext build target to gecko.

Attachments (0)

Change History (5)

comment:1 Changed on 10/09/2017 at 07:17:39 PM by sebastian

  • Blocking 5837 added

comment:2 Changed on 10/10/2017 at 01:06:08 PM by tlucas

  • Owner set to tlucas

comment:3 Changed on 10/10/2017 at 01:14:52 PM by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/11/2017 at 03:38:16 PM by abpbot

A commit referencing this issue has landed:
Issue 5845 - Renaming gecko-webext to gecko

comment:5 Changed on 10/11/2017 at 03:39:11 PM by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
 
Note: See TracTickets for help on using tickets.