Opened on 10/05/2017 at 08:23:27 PM
Closed on 10/12/2017 at 12:02:04 AM
Last modified on 10/12/2017 at 12:31:16 AM
#5837 closed change (fixed)
Update buildtools and adblockplusui dependencies for locale changes
| Reported by: | sebastian | Assignee: | sebasian |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | kzar, tlucas | Blocked By: | #5751, #5763, #5836, #5845 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
- #5763 changed the expected contents of the _locales directory, i.e. es_MX instead of es_419.
- #5751 and #5836 change the way translations are imported. Therefore the buildtools and adblockplusui dependencies need to be updated at the same time.
- #5845 renames the gecko-webext build target to gecko.
The buildtools dependency update also fixes the release automation (#5736) and compatibility with the Crowdin API (#5777 and #5815).
What to change
- Update the dependencies file to refer to revisions of buildtools after #5763 and #5751 landed.
- Update the dependencies file to refer to revisions of adblockplusui after #5836 landed.
- Rename _locales/es_419 to _locales/es_MX.
- Rename metadata.gecko-webext to metadata.gecko.
- Change the import_locales section in metadata.chrome and metadata.gecko to import strings as = * instead of = =*.
Hints for testers
Make sure that all translations are picked up if running the browser in the respective language. Note that some languages are only supported on either Chrome or Firefox.
Attachments (0)
Change History (16)
comment:2 Changed on 10/06/2017 at 05:26:02 PM by sebastian
- Summary changed from Update buildtools dependency and adapt for locale changes to Update buildtools and adblockplusui dependencies for locale changes
comment:3 Changed on 10/09/2017 at 07:17:39 PM by sebastian
- Blocked By 5845 added
- Description modified (diff)
comment:6 Changed on 10/10/2017 at 05:39:53 PM by kzar
- Blocked By 5535 added
- Description modified (diff)
comment:7 in reply to: ↑ description Changed on 10/10/2017 at 05:56:32 PM by sebastian
- Cc kzar added
Replying to kzar:
and the description of #5080 which should possibly be marked as a duplicate of this issue.
If possible, I would like to keep #5080 separate, and only do the minimal changes necessary when updating the buildtools dependency. This dependency update is already becoming complex enough.
comment:8 Changed on 10/10/2017 at 07:21:35 PM by sebastian
- Summary changed from Update buildtools and adblockplusui dependencies for locale changes to Update buildtools+adblockplusui dependencies for locale changes + webpack
comment:9 Changed on 10/11/2017 at 11:12:56 PM by sebastian
- Blocked By 5535 removed
- Cc tlucas added
- Description modified (diff)
- Summary changed from Update buildtools+adblockplusui dependencies for locale changes + webpack to Update buildtools and adblockplusui dependencies for locale changes
I removed the webpack stuff from this dependency update, see ticket:5535#comment:39.
comment:10 Changed on 10/11/2017 at 11:15:32 PM by tlucas
- Description modified (diff)
comment:11 Changed on 10/11/2017 at 11:39:20 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:12 Changed on 10/11/2017 at 11:42:57 PM by sebastian
- Description modified (diff)
comment:13 Changed on 10/11/2017 at 11:58:36 PM by sebastian
- Description modified (diff)
comment:14 Changed on 10/12/2017 at 12:01:14 AM by abpbot
A commit referencing this issue has landed:
Issue 5837 - Updated buildtools and adblockplusui dependencies for locale changes
comment:15 Changed on 10/12/2017 at 12:02:04 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:16 Changed on 10/12/2017 at 12:31:16 AM by sebastian
- Description modified (diff)
I've added some quick integration notes for the webpack changes as Sebastian requested in IRC, since I have to leave now that's all I have time for but I can add more information later if necessary.