Opened on 10/17/2017 at 05:40:35 PM

Closed on 02/27/2018 at 02:20:15 PM

Last modified on 02/27/2018 at 02:24:15 PM

#5870 closed change (fixed)

[emscripten] Implement the new ElemHideEmulation filter type

Reported by: hfiguiere Assignee: hfiguiere
Priority: P3 Milestone:
Module: Core Keywords:
Cc: kzar, greiner, arthur, sebastian, sergz Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29595633/

Description (last modified by hfiguiere)

Background

Issue #5287 implement a new type of filter #?# in C++

What to change

  • Support parsing #?# filters and create ElemHideEmulation filters from that.
  • Convert the old syntax of [-abp-properties=] to the new one.
  • Ensure the content script is up to date.

Attachments (0)

Change History (10)

comment:1 Changed on 10/17/2017 at 05:41:16 PM by hfiguiere

  • Description modified (diff)

comment:2 Changed on 10/17/2017 at 05:41:44 PM by hfiguiere

  • Component changed from Unknown to Core

comment:3 Changed on 11/01/2017 at 03:04:30 PM by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed on 11/02/2017 at 11:48:11 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 01/17/2018 at 04:50:50 PM by sergz

  • Cc kzar greiner arthur sebastian added
  • Priority changed from Unknown to P3

I wonder how long we should actually support the old syntax and whether it's still used somewhere.
@Arthur, could you please share your opinion?

Please feel free to move the discussion somewhere else, in particular if it requires some additional actions.

comment:6 follow-up: Changed on 01/22/2018 at 03:09:40 PM by arthur

@sergz
Could you file a Hub ticket for that? Thanks!

comment:7 in reply to: ↑ 6 Changed on 01/30/2018 at 05:49:47 PM by sergz

  • Cc sergz added

Replying to arthur:

@sergz
Could you file a Hub ticket for that? Thanks!

Please check #7571 in Hub.

comment:8 Changed on 02/27/2018 at 01:31:44 PM by abpbot

A commit referencing this issue has landed:
​Issue 5870 - Implement the new ElemHideEmulation filter type

comment:9 Changed on 02/27/2018 at 02:20:15 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 02/27/2018 at 02:24:15 PM by hfiguiere

Merging the content script is issue #6429

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.