Opened on 10/24/2017 at 02:34:57 PM
Closed on 10/25/2017 at 04:13:49 PM
Last modified on 11/03/2017 at 09:59:54 AM
#5922 closed change (fixed)
Update buildtools in adblockpluschrome to d9e351869c30
| Reported by: | tlucas | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian, oleksandr, greiner | Blocked By: | #5913 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Two regressions are fixed with this dependency upgrade:
| Ticket | Summary | Component |
|---|---|---|
| #5913 | ensure_dependencies.py doesn't install Node.js dependencies on Windows | Automation |
| #5877 | First run page is missing some text | Automation |
What to change
- Change the buildtools dependency in adblockpluschrome to:
| hg | git |
| d9e351869c30 | 076d960 |
- Make sure to include the newer version of ensure_dependencies.py
Note: The only other change included is the addition of some unit tests #5383.
Hints for testers
Check that the missing texts from the first run page mentioned in #5877 have returned.
Attachments (0)
Change History (8)
comment:2 Changed on 10/25/2017 at 03:44:12 PM by tlucas
- Description modified (diff)
- Summary changed from Update buildtools and adblockplusui dependency in adblockpluschrome to resolve a npm related regression to Update buildtools in adblockpluschrome to d9e351869c30
comment:4 Changed on 10/25/2017 at 03:55:08 PM by kzar
- Description modified (diff)
- Owner set to kzar
- Priority changed from Unknown to P1
- Ready set
comment:5 Changed on 10/25/2017 at 04:00:15 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 10/25/2017 at 04:11:14 PM by abpbot
A commit referencing this issue has landed:
Issue 5922 - Update buildtools dependency to revision d9e351869c30
comment:7 Changed on 10/25/2017 at 04:13:49 PM by kzar
- Blocked By 5921 removed
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 11/03/2017 at 09:59:54 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 1.13.4.1903
Chrome 49 / 62 / Windows 10
Opera 36 / 48 / Windows 10
ABP 2.99.0.1902beta
Firefox 50 / 57 / Windows 10
Note: See
TracTickets for help on using
tickets.
We might want to wait until fixes for #5915 and #5916 are fixed before doing this dependency update?