Opened on 11/14/2017 at 01:39:33 PM
Closed on 11/18/2017 at 12:25:52 PM
Last modified on 10/08/2019 at 06:03:33 PM
#6036 closed defect (fixed)
[webextension] The ABP icon by our devtools pane is blurry
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | trev, sebastian, Ross | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Firefox 57, Windows 10, adblockpluschrome 02cd0e01c0ba
How to reproduce
- Open a new tab.
- Open the developer tools for that tab.
Observed behaviour
Our developer tools pane is listed, but the ABP icon next to "Adblock Plus" is very blurry.
Expected behaviour
The icon should appear sharp, not blurry.
Hints for testers
Open the Firefox developer tools and look at the ABP icon by our developer tools pane. On retina screens it should look sharp, on lower def screens it should look a little blurry, but make sure it doesn't look as blurry as before. (See the attached screenshot.)
Attachments (1)
Change History (8)
Changed on 11/14/2017 at 03:51:12 PM by kzar
comment:1 Changed on 11/14/2017 at 03:54:34 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/17/2017 at 12:48:31 PM by trev
comment:3 Changed on 11/18/2017 at 12:23:01 PM by abpbot
A commit referencing this issue has landed:
Issue 6036 - Use correct resolution for devtools pane icon
comment:4 Changed on 11/18/2017 at 12:25:52 PM by kzar
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 11/29/2017 at 08:15:59 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Looks better on both retina and smaller screens.
ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Chrome 49 / 62 / Windows 7
Opera 36 / 48 / Windows 7
comment:6 Changed on 03/20/2019 at 06:41:45 AM by Thanos
spam
comment:7 Changed on 10/07/2019 at 05:12:54 AM by Henshaw34
spam
For reference, I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1418299 on the API not allowing multiple icon sizes.