Opened on 11/14/2017 at 06:11:44 PM
Closed on 11/14/2017 at 08:46:56 PM
Last modified on 12/05/2017 at 01:11:49 PM
#6038 closed defect (fixed)
Update adblockplusui dependency to d414ee80d886
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | #6035 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
With issue #6035 we worked around a limitation with Firefox 57 which meant that clicking on requests in our developer tools pane didn't work. We now need to update the adblockplusui dependency to make use of that.
What to change
Update the adblockplusui dependency to:
| mercurial | git |
| d414ee80d886 | 4bc1d98 |
No other changes will be included.
Hints for testers
The resource clicked should be displayed in the devtools properly where the API is supported (Chrome) but open in a new tab otherwise (Firefox).
Attachments (0)
Change History (4)
comment:1 Changed on 11/14/2017 at 06:18:50 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/14/2017 at 08:46:32 PM by abpbot
comment:3 Changed on 11/14/2017 at 08:46:56 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 12/05/2017 at 01:11:49 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. In Firefox resources are opened in a new tab, in Chrome/Opera they open in the devtools.
ABP 3.0.1.1939
Firefox 52 / 57 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6038 - Update adblockplusui dependency to d414ee80d886