Opened on 11/14/2017 at 03:29:49 PM

Closed on 11/21/2017 at 07:37:00 AM

Last modified on 11/21/2017 at 12:58:22 PM

#6037 closed change (fixed)

Allow popup icons without popup

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: #5977 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29608569/

Description

Background

For #5977 we need to set the popup dynamically in code rather than via the manifest file. But there's currently no way to specify the popup icons in buildtools without also setting the popup.

What to change

In packagerChrome.py, consider the last icon to be the popup only if the name ends in .html.

Attachments (0)

Change History (9)

comment:1 Changed on 11/14/2017 at 03:31:09 PM by mjethani

  • Owner set to mjethani

comment:2 Changed on 11/14/2017 at 03:31:53 PM by mjethani

  • Cc kzar sebastian added

comment:3 Changed on 11/14/2017 at 04:02:49 PM by tlucas

  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed on 11/14/2017 at 06:37:00 PM by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/16/2017 at 05:34:34 PM by abpbot

A commit referencing this issue has landed:
​Issue 6037 - Allow popup icons without popup

comment:6 Changed on 11/21/2017 at 07:37:00 AM by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 follow-up: Changed on 11/21/2017 at 07:37:24 AM by mjethani

What should be the milestone for this one?

comment:8 in reply to: ↑ 7 ; follow-up: Changed on 11/21/2017 at 12:55:16 PM by kzar

Replying to mjethani:

What should be the milestone for this one?

No, the ticket that updates the buildtools dependency for adblockpluschrome will have a milestone assigned. (That's why it's important the dependency update ticket makes it clear what needs testing.)

comment:9 in reply to: ↑ 8 Changed on 11/21/2017 at 12:58:22 PM by mjethani

Replying to kzar:

Replying to mjethani:

What should be the milestone for this one?

No, the ticket that updates the buildtools dependency for adblockpluschrome will have a milestone assigned. (That's why it's important the dependency update ticket makes it clear what needs testing.)

I see, thanks.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.