Opened on 11/20/2017 at 03:38:02 PM
Closed on 11/27/2017 at 02:34:24 PM
#6060 closed change (fixed)
Provide lead style in website-defaults
| Reported by: | juliandoucette | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | ire, saroyanm | Blocked By: | |
| Blocking: | #6047 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Inspired by bootstrap/.lead
A "lead" paragraph is an emphasized introductory paragraph that is not a subtitle.
It is typically visually emphasized, not semantically emphasized, like strong or em.
What to change
Suggested style:
.lead
{
font-size: 1.25em;
}
Attachments (0)
Change History (8)
comment:2 Changed on 11/20/2017 at 03:39:46 PM by juliandoucette
- Owner set to juliandoucette
comment:3 Changed on 11/20/2017 at 03:40:04 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 11/20/2017 at 03:45:19 PM by juliandoucette
- Blocking 6047 added
comment:5 in reply to: ↑ 1 ; follow-up: ↓ 6 Changed on 11/27/2017 at 08:43:14 AM by ire
Replying to juliandoucette:
I found a use for this on the uninstalled page where "Please select the reason(s) why you uninstalled Adblock Plus:" should be visually emphasized and not a heading (IMO).
That particular use case seems like it should be a label IMO.
I like the idea of a lead style. Although not currently in HC styleguide I think it could be useful there.
comment:6 in reply to: ↑ 5 Changed on 11/27/2017 at 01:01:53 PM by juliandoucette
Replying to ire:
That particular use case seems like it should be a label IMO.
Good catch!
(I will use the lead class on the label.)
comment:7 Changed on 11/27/2017 at 02:33:18 PM by abpbot
A commit referencing this issue has landed:
Issue 6060 - Provided lead style in utilities
comment:8 Changed on 11/27/2017 at 02:34:24 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
I found a use for this on the uninstalled page where "Please select the reason(s) why you uninstalled Adblock Plus:" should be visually emphasized and not a heading (IMO).