Opened on 11/20/2017 at 03:43:48 PM

Closed on 12/20/2017 at 06:19:19 PM

#6061 closed defect (fixed)

website-defaults unstyled ul doesn't unstyle li

Reported by: juliandoucette Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, saroyanm Blocked By:
Blocking: #6047 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29612659/

Description

Environment

All.

How to reproduce

Apply .unstyled to a ul with lis

Observed behaviour

lis have list-style-type

Expected behaviour

lis should not have list-style-type

Notes

This may be by-design (e.g. suggesting that we should apply .unstyled to each list item). But that would be inconvinient (IMO) inconsistent with our .unstyled * style(IMO). I think we should apply list-style: none to .unstyled ul lis.

Attachments (0)

Change History (6)

comment:1 Changed on 11/20/2017 at 03:43:55 PM by juliandoucette

  • Owner set to juliandoucette

comment:2 Changed on 11/20/2017 at 03:44:07 PM by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/20/2017 at 03:45:19 PM by juliandoucette

  • Blocking 6047 added

comment:4 Changed on 12/05/2017 at 02:45:20 PM by juliandoucette

  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed on 12/06/2017 at 03:42:21 PM by abpbot

A commit referencing this issue has landed:
​Issue 6061 - Added important to unstyled utility

comment:6 Changed on 12/20/2017 at 06:19:19 PM by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from juliandoucette.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.