Opened on 12/06/2017 at 05:36:12 PM
Closed on 12/06/2017 at 06:09:09 PM
Last modified on 12/11/2017 at 10:00:13 AM
#6169 closed change (fixed)
Update adblockplusui dependency to revision 0e99fec067ea
| Reported by: | saroyanm | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.0.2-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | trev, sebastian, Shikitita, Ross | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29631579 |
||
Description (last modified by kzar)
Background
We've been working to improve the translations of the new Acceptable Ads and EasyPrivacy conflict message. We need to update the adblockplusui dependency of adblockpluschrome now in order to include those translations for the Adblock Plus 3.0.2 for Firefox release.
What to change
Update the adblockplusui dependency to hg:0e99fec067ea git:c4e39c7
Included changes in adblockplusui
The list of changes imported by this is:
| Ticket | Summary | Component |
|---|---|---|
| #6170 | Import Acceptable Ads conflict notification translations | User-Interface |
| #6163 | Fix incorrect source strings in Options page project | User-Interface |
| #6110 | New options page does not display correctly in Chrome 49-51 | User-Interface |
| #6103 | No attribute error when running build script | User-Interface |
| #6102 | Update buildtool dependencies in the adblockplusui to f92050874f05 | User-Interface |
Apart from the updated translations none of those changes are relevant, they are either to the build system (used for synchronising translations) or to the test page.
Hints for testers
Ensure the Acceptable Ads and privacy warning displays OK in different languages.
Attachments (0)
Change History (11)
comment:2 Changed on 12/06/2017 at 05:49:08 PM by saroyanm
- Description modified (diff)
- Summary changed from Update adblockplusui dependencies to "rev" to Update adblockplusui dependencies to 0e99fec067ea
comment:3 Changed on 12/06/2017 at 05:52:59 PM by saroyanm
- Cc kzar sebastian added
- Component changed from Unknown to Platform
comment:5 Changed on 12/06/2017 at 05:55:58 PM by kzar
comment:7 Changed on 12/06/2017 at 06:05:33 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Summary changed from Update adblockplusui dependencies to revision 0e99fec067ea to Update adblockplusui dependency to revision 0e99fec067ea
comment:8 Changed on 12/06/2017 at 06:08:33 PM by abpbot
comment:9 Changed on 12/06/2017 at 06:09:09 PM by kzar
- Milestone set to Adblock-Plus-3.0.2-for-Chrome-Opera-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 12/06/2017 at 06:22:30 PM by kzar
- Cc Ross added
The release has been delayed until Tuesday the 12th, Ross any chance you could have a look at testing this issue before then?
comment:11 Changed on 12/11/2017 at 10:00:13 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. The acceptable ads message displays correctly in the languages I've tried (languages where the language pack has been updated for FF57).
ABP 3.0.1.1943
Firefox 52 / 57 / Windows 7
A commit referencing this issue has landed:
Issue 6169 - Update adblockplusui dependency to revision 0e99fec067ea