Opened on 08/27/2018 at 02:04:54 PM
Closed on 09/01/2018 at 03:30:55 PM
Last modified on 10/18/2018 at 11:45:00 AM
#6887 closed change (fixed)
Run qunit tests in adblockpluschrome in chrome
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, hfiguiere | Blocked By: | |
| Blocking: | #6890 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
In #6717, we added a feature to automatically run the integrated qunit tests in a headless Firefox instance with npm test. After we switched to mocha as our test suite (#6884), we can now easily setup the same test for multiple browsers.
What to change
- Add chrome support to adblockpluschromes nodejs environment.
- Change the "test" script in package.json to build a devenv for the target browser(s).
- Let npm test (with no arguments) run the qunit tests on both Firefox(headless) and Chrome.
- Let npm test's target Browser be switchable with arguments analog to the targets in our buildtools, analog to mocha's usage i.e.:
$ npm test #Run tests in all supported browsers $ npm test -- -g gecko #Run tests in Firefox only $ npm test -- -g chrome #Run tests in Chrome only $ npm test -- -g "[gecko|chrome]" #Run tests in both Firefox and Chrome only
Attachments (0)
Change History (7)
comment:3 Changed on 08/27/2018 at 03:09:52 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/28/2018 at 08:29:50 AM by tlucas
- Blocking 6890 added
comment:5 Changed on 09/01/2018 at 03:30:21 PM by abpbot
comment:6 Changed on 09/01/2018 at 03:30:55 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 10/18/2018 at 11:45:00 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Working as expected.
adblockpluschrome / master / 2175:02d136073262
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6887 - add Chrome to "npm test"