Opened on 08/27/2018 at 04:55:09 PM

Closed on 08/29/2019 at 05:43:52 PM

#6888 closed change (rejected)

[emscripten] Remove support for legacy :-abp-properties() syntax

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: sergz Blocked By: #6870
Blocking: #4122 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29867635
​https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/7

Description (last modified by hfiguiere)

Background

Issue #6870 remove support for legacy :-abp-properties() syntax. We should do the same in the C++ code.

What to change

Remove the code, update the tests.

Attachments (0)

Change History (6)

comment:1 Changed on 08/27/2018 at 04:55:36 PM by hfiguiere

  • Blocked By 6870 added
  • Blocking 4122 added

comment:2 Changed on 08/27/2018 at 04:55:55 PM by hfiguiere

  • Description modified (diff)

comment:3 Changed on 08/29/2018 at 03:00:01 AM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/29/2018 at 03:00:13 AM by hfiguiere

  • Owner set to hfiguiere

comment:5 Changed on 11/30/2018 at 03:22:09 PM by hfiguiere

  • Review URL(s) modified (diff)

comment:6 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.