Opened on 08/27/2018 at 04:55:09 PM
Closed on 08/29/2019 at 05:43:52 PM
#6888 closed change (rejected)
[emscripten] Remove support for legacy :-abp-properties() syntax
Reported by: | hfiguiere | Assignee: | hfiguiere |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Core | Keywords: | closed-in-favor-of-gitlab |
Cc: | sergz | Blocked By: | #6870 |
Blocking: | #4122 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29867635 |
Description (last modified by hfiguiere)
Background
Issue #6870 remove support for legacy :-abp-properties() syntax. We should do the same in the C++ code.
What to change
Remove the code, update the tests.
Attachments (0)
Change History (6)
comment:1 Changed on 08/27/2018 at 04:55:36 PM by hfiguiere
- Blocked By 6870 added
- Blocking 4122 added
comment:3 Changed on 08/29/2018 at 03:00:01 AM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/29/2018 at 03:00:13 AM by hfiguiere
- Owner set to hfiguiere
comment:6 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.