Opened on 09/05/2018 at 02:23:39 PM
Closed on 08/30/2019 at 04:40:02 PM
#6930 closed change (rejected)
Add support for Microsoft Edge to WebDriver-based test automation
| Reported by: | sebastian | Assignee: | geo |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | geo, tlucas | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Since #6717, #6887 and #6918 landed, running npm test in adblockpluschrome will run the qunit tests and test Adblock Plus against the test pages in Chromium and Firefox. It would be great to have the same automation for Microsoft Edge (and eventually run it through the CI).
What to change
Implement test/browsers/edge.js (analogous to chromium.js and firefox.js in test/browsers/), so that running npm test on Windows will run the tests as well on Microsoft Edge.
Skip testing Microsoft Edge if running on an OS other than Windows (so that the tests don't fail on Linux and macOS). Unlike for Chromium and Firefox, don't download a specific version of the browser, just use the version of Microsoft Edge that came with the running version of Windows.
Attachments (0)
Change History (5)
comment:2 Changed on 09/27/2018 at 11:53:17 AM by geo
- Owner set to geo
comment:3 Changed on 09/27/2018 at 04:20:01 PM by sebastian
comment:5 Changed on 08/30/2019 at 04:40:02 PM by sebastian
- Resolution set to rejected
- Status changed from new to closed
With the deprecation of the EdgeHTML-based Microsoft Edge, I think we no longer need pursue this.
For reference: https://docs.microsoft.com/en-us/microsoft-edge/extensions/guides/packaging/creating-and-testing-extension-packages#automated-testing-with-webdriver