Opened on 12/11/2014 at 02:09:45 PM
Closed on 09/21/2017 at 04:53:39 AM
#1687 closed change (duplicate)
Use signatures.js from adblockplustests in adblockpluschrome
Reported by: | greiner | Assignee: | |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Platform | Keywords: | |
Cc: | sebastian | Blocked By: | #698, #1723 |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by sebastian)
Background
In #698 we implement unit tests for the $sitekey functionality and move signature tests to adblockplustests. That means that we can remove those tests from adblockpluschrome and import it from adblockplustests instead.
What to change
- Remove /qunit/tests/signatures.js from adblockpluschrome
- Add mapping for /chrome/content/tests/signatures.js from adblockplustests to metadata.common
Hints for testers
No testing required. The changed code isn't included in the builds.
Attachments (0)
Change History (4)
comment:1 Changed on 12/11/2014 at 03:52:50 PM by sebastian
- Cc sebastian added
- Description modified (diff)
- Ready set
comment:2 Changed on 12/11/2014 at 04:27:01 PM by sebastian
- Priority changed from Unknown to P4
Note: See
TracTickets for help on using
tickets.
I'm going to update the dependencies one week prior to the release. Feel free to already work on this, having a patch ready to be pushed, when the subrepo is updated.