Opened on 10/02/2018 at 08:50:39 AM

Closed on 10/09/2018 at 09:12:59 AM

#7008 closed change (fixed)

Update adblockpluscore dependency to revision git:9fba045086ff73e3986fac2fefda86f8e8f79468

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/libadblockplus/merge_requests/22

Description (last modified by zkhetsuriani)

Background

There were some changes in the core, most notably the addition of IndianList filter list to subscriptions.xml and we should update it in libadblockplus.

The list of changes imported by this is (these are issue numbers extracted from commits):


b67d0e4Noissue - Fix ESLint error for getComputedCSSText JSDocManish Jethani
dedce2fNoissue - Fix Firefox executable path for WindowsGeorgiana Piscoi
1110c5fNoissue - Account for spaces in Firefox installer path nameSebastian Noack
de3f507Noissue - Avoid redundant lookup in keyword-by-filter mapManish Jethani

What to change

  • accomplish this issue description by adding the exact version (git commit) and the list of changes, see example in #6860
  • do all required changes in libadblockplus

Attachments (0)

Change History (3)

comment:1 Changed on 10/02/2018 at 08:51:04 AM by sergz

  • Description modified (diff)

comment:2 Changed on 10/05/2018 at 03:06:17 PM by zkhetsuriani

  • Description modified (diff)
  • Summary changed from Update adblockpluscore dependency to revision git:TBD to Update adblockpluscore dependency to revision git:9fba045086ff73e3986fac2fefda86f8e8f79468

comment:3 Changed on 10/09/2018 at 09:12:59 AM by zkhetsuriani

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.