Update adblockpluscore dependency to revision git:2551978

[sergz]

Background

There were a lot of changes in the core, most notably they concern the memory usage and support of new filters, like snippets.

The list of changes imported by this is (these are issue numbers extracted from commits):

Ticket	Summary	Component
#6944	Update subscriptions.xml to include EasyList Portuguese filter list	Core
#6931	localhost isn't considered a domain by contentfilter validating code	Core
#6927	Add pattern property to RegExpFilter to expose already extracted pattern	Core
#6923	Only parse metadata from special comments at the top of the file	Core
#6919	Implement hide-if-contains-and-matches-style snippet	Core
#6916	Avoid Set object for filters with only one subscription	Core
#6908	Pass updated subscription's old filters as an event argument	Core
#6893	Split out the INIParser class into its own file	Core
#6886	Add support for looking up SnippetFilter objects for a domain	Core
#6883	Remove Filter.toRegExp function	Core
#6871	Extension incorrectly accepts $csp filters with blank value	Core
#6870	Remove support for legacy :-abp-properties() syntax	Core
#6868	Rewrite filter with wildcard doesn't match end of URL	Core
#6862	Make Snippets module emit events	Core
#6855	Remove Subscription object from memory when unsubscribed	Core
#6854	Remove deprecated FilterNotifier methods	Core
#6853	Write unit tests for undocumented quirks in snippet script parsing	Core
#6849	Remove redundant logic parsing checksums from filter lists	Core
#6848	Add support to hide-if-contains for hiding a different ancestor of the element containing the search string	Core
#6847	Add regular expression support to hide-if-contains and hide-if-shadow-contains snippets	Core
#6823	Remove unnecessary usage of the /u flag in regular expressions	Core
#6815	Avoid multiple copies of domain maps	Core
#6814	Avoid redundant calls to ActiveFilter.domains getter	Core
#6811	Blank values for snippet arguments are ignored	Core
#6809	Implement hide-if-contains snippet	Core
#6803	Implement readd snippet	Core
#6798	Implement hide-if-shadow-contains snippet	Core
#6797	Require active domains in snippet filters	Core
#6790	Implement uabinject-defuser snippet for AdDefend	Core
#6781	Implement basic support for snippet filters	Core
#6741	Use ECMAScript 2015 classes	Core
#6737	Use String.includes instead of String.indexOf where the index is not needed	Core
#6735	Store domains in lower case	Core
#6733	Allow empty values in filter options	Core
#6727	Use string rather than map for single-domain filters	Core
#6704	Ignore $rewrite filters for requests loading code to be executed	Core
#6690	Trailing periods are not treated consistently between filter types	Core
#6689	Add anti-circumvention filter list to the recommended subscription list	Core
#6680	Element hiding emulation doesn't work with :-abp-properties() and dynamic DOM updates	Core
#6669	Replace critera argument to ElemHide.getSelectorsForDomain with specificOnly	Core
#6665	Share functionality and optimizations between ElemHide and ElemHideEmulation	Core
#6652	Implement fast selector lookups for most domains	Core
#6651	Introduce CI for Adblock Plus (devbuilds)	Automation
#6649	Allow the Unicode flag in :-abp-contains() regular expressions	Core
#6619	Element hiding emulation injects incorrect CSS selector for :-abp-properties() when the selector in the document's style sheet is a compound selector	Core
#6610	Use inline style for -abp-properties if there's no tabs.removeCSS support	Core
#6592	Add filter option to rewrite URL	Core
#6562	Remove provideFilterKeys parameter from getSelectorsForDomain and associated logic	Core
#6559	Use maps and sets where appropriate	Core
#6538	Implement support for snippet filters	Core
#6505	Make use of default function parameters in Core module	Core
#6504	Implement ElemHideEmulation.useInlineStyles property	Core
#6467	Use Map object for caching filter matches	Core
#6437	Optimize element hiding emulation for DOM modifications	Core
#6434	Define helpers for non-array iterables	Core
#6423	Observe only relevant mutation types in elemHideEmulation.js	Core
#6421	Update subscriptions.xml to include EasyList Polish	Core
#6391	Run browser tests with headless Firefox as well as Chromium	Core
#6382	:-abp-contains() + div not working in Firefox	Platform
#6329	Add support for $csp filter option to core	Core
#6296	Procedural hiding stops working when ...:-abp-has(> ...:-abp-contains(...)) is used	Core
#6220	add CI for adblockpluscore	Core
#6034	Add support for regular expressions in :-abp-contains()	Core
#5956	[webextension] :-abp-has() fail in Firefox	Core
#5762	Use relative require paths in adblockpluscore	Core
#5504	Update comment in accordance with the code	Core
#1846	Remove the locale parameter of Notification.getLocalizedTexts	Core

​46ffcc4	Noissue - Remove extra blank line in lib/matcher.js	Manish Jethani
​4b3326c	Noissue - Return value of filter match expression directly	Manish Jethani
​655ff97	Noissue - Define RegExpFilter's 0 getter statically	Manish Jethani
​9ac10ab	Noissue - Check for comment indicator first while parsing filter text	Manish Jethani
​821d706	Noissue - Delete element hiding domain entry once all filters removed	Manish Jethani
​d811099	Noissue - Avoid :-abp-properties() legacy syntax parsing for most filters	Manish Jethani
​2fc20a4	Noissue - Update comment on :-abp-properties() DOM dependence	Manish Jethani
​a2773c0	Noissue - Add a test to confirm an evil rewrite gets cancelled	Hubert Figuière
​5ecee61	Noissue - Add @link tag for JSDoc references	Manish Jethani
​42b20fe	Noissue - Remove unnecessary references to undefined	Manish Jethani
​be95169	Noissue - Remove redundant assignment to zero	Manish Jethani
​ef3749f	Noissue - Add criteria test for ~example.com##world	Manish Jethani
​81c64f3	Noissue - Check only first two characters for exception marker	Manish Jethani
​df18e31	Noissue - Remove workaround for WebKit getter misoptimization	Manish Jethani
​e04e8ca	Noissue - Avoid setting ActiveFilter.domainSource	Manish Jethani
​00210e9	Noissue - Avoid setting BlockingFilter instance properties	Manish Jethani
​5bd94d6	Noissue - Avoid delete operator on RegExpFilter.regexpSource	Manish Jethani
​4e136fa	Noissue - Remove ElemHideBase.selectorDomains	Manish Jethani
​8be0963	Noissue - Avoid redundant iterations in subscriptions loop	Manish Jethani
​f77da12	Noissue - Discard regular expression source when no longer needed	Manish Jethani
​f75f0ce	Noissue - Fix JSDoc type for exceptions in lib/elemHide.js	Manish Jethani
​60a41e8	Noissue - Make private functions inaccessible via ElemHide object	Manish Jethani
​42fbb57	Noissue - Update JSDoc to mark optionals in lib/filterClasses.js	Manish Jethani
​efd99fe	Noissue - Use default parameters	Manish Jethani
​4222d52	Noissue - Update JSDoc to mark optionals in lib/elemHide.js	Manish Jethani
​aef75c4	Noissue - Update JSDoc @type for Matcher.filterByKeyword	Manish Jethani
​c9221c1	Noissue - Use plural for element hiding domains	Manish Jethani
​8028eea	Noissue - Compare individual characters instead of substring	Manish Jethani
​7b7286a	Noissue - Trim spaces around element hiding emulation selectors	Manish Jethani
​66b307d	Noissue - Check for null and blank string instead of undefined	Manish Jethani
​5efe12d	Noissue - Use Map to store EventEmitter listeners	Dave Barker
​95a7b57	Noissue - Access document via this	Manish Jethani
​314bda3	Noissue - Allow identifying the element in case of error in test	Hubert Figuière
​ff18e95	Noissue - Change specialization for "ABPVN List+EasyList"	Sergei Zabolotskikh
​0d3c182	Noissue - Fix naming inconsistency in ContainsSelector	Manish Jethani
​7af872b	Noissue - Fix the escaping of '{' and '}' in CSS selectors	Hubert Figuière
​2b57122	Noissue - Fixed typo with getLocalizedTexts function Review: ​https://codereview.adblockplus.org/29567746/	Dave Barker
​662ce93	Noissue - Updated recommended subscriptions	Wladimir Palant

What to change

Adapt the code in accordance with the made changes in the core.

• Change require() in lib/compat.js to strip the leading ./ from module names`
• Change isListedFilter() in lib/api.js since Filter.subscription is no longer a property but a generator function.
• Change isListedSubscription() in lib/api.js since FilterStorage.knownSubscriptions is a Map object and not an array anymore.
• Change lib/filterUpdateRegistration.js to use the new event API, by listening to all the individual events and binding them to emit filterChange
• Import filterNotifier instead of FilterNotifier (singleton , not class)
• In init.js change the load event listener to use the new event API
• Add the new JS files to the build in libadblockplus.gyp

It also seems it makes sense to implement certain functionality in libadblockplus as the following up issues, e.g. introduce the API to work with snippets.

[hfiguiere]

Merged in ​https://gitlab.com/eyeo/adblockplus/libadblockplus/commit/ed692a2990ae1e75e2db7a9aa9009f4684de5087