#7019 closed change (fixed)

[CMS] Refactor `test_server.py`

Reported by:	atudor	Assignee:	atudor
Priority:	Unknown	Milestone:
Module:	Sitescripts	Keywords:
Cc:	kvas, jsonesen	Blocked By:
Blocking:	#6337	Platform:	Unknown / Cross platform
Ready:	no	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29912588/

The days of CMS are coming to an end. Slowly, but steadily, it's starting to change shape. Now it's test_server.py's time to be refactored :D.

Refactor test_server.py. The key targets when refactoring this code are:

Making it PEP8 compliant. There are a couple of flake8 exceptions that are added for the current implementation and which can be easily be handled: A101, A107, A302, E501, F401
Make the code more easily readable. The most important thing here is adding docstrings to all the functions involved.
Increase test coverage from 69%.

Where possible, some performance enhancements will be included as well.

A commit referencing this issue has landed:
Issue 7019 - Refactor test_server.py

Summary:
Description:	You may use WikiFormatting here. === Background === The days of CMS are coming to an end. Slowly, but steadily, it's starting to change shape. Now it's `test_server.py`'s time to be refactored :D. === What to change === Refactor `test_server.py`. The key targets when refactoring this code are: 1. Making it PEP8 compliant. There are a couple of `flake8` exceptions that are added for the current implementation and which can be easily be handled: `A101, A107, A302, E501, F401` 2. Make the code more easily readable. The most important thing here is adding docstrings to all the functions involved. 3. Increase test coverage from 69%. Where possible, some performance enhancements will be included as well.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29912588/