Opened on 10/31/2018 at 07:15:14 PM
Closed on 10/31/2018 at 07:16:49 PM
Last modified on 11/07/2018 at 11:17:43 AM
#7087 closed change (fixed)
Update buildtools dependency to f5c7b0b57d3b
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
The builds for Microsoft Edge are still rejected by the Windows Store (see #7080), and the release automation currently fails (see #7083).
Included changes in buildtools
The list of changes imported by this is:
What to change
Update the buildtools dependency to:
| mercurial | git |
| f5c7b0b57d3b | 41798f6 |
Hints for testers
This dependency update should have no effect on the builds for Chrome and Firefox. For Microsoft Edge make sure that the development builds are automatically published on the Windows Store again, and that the untranslated product name (i.e. "Adblock Plus" or "Adblock Plus development build") shows up correctly on the Windows Store and inside Microsoft Edge.
Attachments (0)
Change History (3)
comment:1 Changed on 10/31/2018 at 07:16:21 PM by abpbot
comment:2 Changed on 10/31/2018 at 07:16:49 PM by sebastian
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 11/07/2018 at 11:17:43 AM by wspee
- Milestone set to Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox
Since this is already in master I'll assume it's fine to include in Adblock-Plus-3.4.1-for-Chrome-Opera-Firefox, please let me know if this should be backed-out instead.
A commit referencing this issue has landed:
Issue 7087 - Updated buildtools depdendency to f5c7b0b57d3b