Opened on 11/28/2018 at 03:35:33 PM

Closed on 01/17/2019 at 01:51:23 PM

Last modified on 01/23/2019 at 12:23:22 AM

#7146 closed change (fixed)

Add manifest name for release builds

Reported by:	wspee	Assignee:
Priority:	Unknown	Milestone:
Module:	User-Interface	Keywords:
Cc:		Blocked By:
Blocking:	#7219	Platform:	Unknown / Cross platform
Ready:	no	Confidential:	no
Tester:	Ross	Verified working:	yes
Review URL(s):	https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/175

Description (last modified by wspee)

Background

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/257

What to change

Add new string name_releasebuild with the value Adblock Plus - free ad blocker to be used as the name key in the manifest file for release builds.

Change History (13)

comment:1 Changed on 11/28/2018 at 03:35:42 PM by wspee

Blocked By 7145 added

comment:2 Changed on 11/28/2018 at 03:51:21 PM by wspee

Description modified (diff)
Review URL(s) modified (diff)
Status changed from new to reviewing

comment:3 Changed on 11/30/2018 at 02:36:59 PM by wspee

Blocked By 7145 removed

comment:4 Changed on 11/30/2018 at 02:37:43 PM by wspee

Blocking 7145 added

comment:5 Changed on 12/17/2018 at 06:11:53 PM by wspee

Blocking 7145 removed
Description modified (diff)

comment:6 Changed on 12/27/2018 at 10:41:52 AM by wspee

Description modified (diff)
Summary changed from Add translation for new chrome extension name used in manifest for cws to Change manifest name for release builds

comment:7 Changed on 12/27/2018 at 11:26:45 AM by wspee

Description modified (diff)
Summary changed from Change manifest name for release builds to Add manifest name for release builds

comment:8 Changed on 12/27/2018 at 11:36:56 AM by wspee

Blocking 7145 added

comment:9 Changed on 01/16/2019 at 04:05:39 PM by wspee

Blocking 7219 added

comment:10 Changed on 01/17/2019 at 03:10:34 AM by sebastian

Blocking 7145 removed

comment:11 Changed on 01/17/2019 at 01:30:59 PM by abpbot

A commit referencing this issue has landed:
Issue 7146 - Change manifest name for release builds

comment:12 Changed on 01/17/2019 at 01:51:23 PM by wspee

Resolution set to fixed
Status changed from reviewing to closed

comment:13 Changed on 01/23/2019 at 12:23:22 AM by Ross

Tester changed from Unknown to Ross
Verified working set

Done. New name appears in all browsers.

ABP 3.4.2.2231
Chrome 71.0.3578.98 / Windows 10 (Latest)
Chrome 49.0.2623.75 / Windows 10 (Min supported)
Firefox 64.0.2 / Windows 10 (Latest)
Firefox 51.0 / Windows 10 (Min supported)
Opera 57.0.3098.76 / Windows 10 (Latest)
Opera 36.0.2130.65 / Windows 10 (Min supported)

Context Navigation