Opened on 11/28/2018 at 03:23:13 PM
Closed on 01/17/2019 at 03:10:42 AM
Last modified on 01/23/2019 at 12:25:47 AM
#7145 closed change (fixed)
Change manifest name for release builds
| Reported by: | wspee | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | #7219 | Platform: | Chrome |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by wspee)
Background
The title is one of the key factors in determining the search result position in the addon stores (CWS, AMO, etc.). Adblock Plus currently doesn't rank in the top 3 for the keyword ad blocker (see CWS, AMO, Opera, MS) which is one of the highest volume adblocking related search term currently. We need to update the title to make sure Adblock Plus is one of the top 3 results.
What to change
As specified here in order to update the extension name to Adblock Plus - free ad blocker change the i18n message used in the manifest file to __MSG_name_releasebuild__.
Note
See #7146 for the actual name
Attachments (0)
Change History (24)
comment:2 Changed on 11/28/2018 at 03:32:45 PM by wspee
- Summary changed from Change chrome extension name for cws to Change chrome extension name used in manifest for cws
comment:3 Changed on 11/28/2018 at 03:35:42 PM by wspee
- Blocking 7146 added
comment:4 Changed on 11/28/2018 at 03:46:37 PM by wspee
- Cc sebastian kzar added
- Component changed from Adblock-Plus-for-Chromium to Platform
- Platform changed from Unknown / Cross platform to Chrome
- Review URL(s) modified (diff)
comment:6 Changed on 11/28/2018 at 03:50:42 PM by wspee
comment:7 Changed on 11/28/2018 at 03:58:45 PM by kzar
- Status changed from new to reviewing
If it's OK I'd rather wait for Sebastian to get back before triaging this one. But no harm in it having the reviewing status in the mean time.
comment:8 Changed on 11/28/2018 at 04:06:01 PM by wspee
Yeah no problem. I warned him about this coming a few weeks ago ;). We are aiming for the 3.5 codefreeze with this so waiting should be fine.
Some more text to trick trac's spam detection :P
comment:10 Changed on 11/30/2018 at 02:36:59 PM by wspee
- Blocking 7146 removed
comment:11 Changed on 11/30/2018 at 02:37:43 PM by wspee
- Blocked By 7146 added
comment:12 Changed on 11/30/2018 at 09:59:40 PM by sebastian
Note that the same builds are published on the CWS and on Opera Add-Ons. So please don't mention "Google Chrome" in the product name that will show as well on Opera Add-Ons. (For reference, we mentioned, Google Chrome before in the short description, and Opera wasn't happy about that.)
comment:13 Changed on 12/03/2018 at 09:29:20 PM by wspee
Ok, good to know. I think we definitely don't want to "advertise" abp for opera with for Google Chrome in it's name :P. I'll check back and see if we can find another alternative.
In case we don't I guess I could still prepare a change to introduce an opera specific manifest file. What are the other things that would need to be considered? Update the release checklist? Anything else? I hope the overhead created by this would not be to large?
comment:14 Changed on 12/04/2018 at 10:22:41 PM by sebastian
Currently, we don't have Opera-specific builds. So if we want to have different metadata on Opera and Chrome, we'd have to introduce a new build target and change our release automation. I'd rather not go there, just for a marketing experiment, but would very much prefer to just keep the product name browser agnostic.
comment:15 Changed on 12/17/2018 at 06:09:32 PM by wspee
- Resolution set to rejected
- Status changed from reviewing to closed
We have agreed to go with a browser agnostic name instead, see https://gitlab.com/eyeo/websites/abp-cws/issues/22#note_125601082 as a result this change to add a chrome specific name is no longer needed. Thanks for all your inputs :)
comment:16 Changed on 12/17/2018 at 06:11:53 PM by wspee
- Blocked By 7146 removed
comment:17 Changed on 12/17/2018 at 09:31:22 PM by sebastian
- Component changed from Platform to Automation
- Resolution rejected deleted
- Status changed from closed to reopened
Note that the string name is currently not only used for the extension name (as shown in the web stores and on the extension management page), but also for the manifest keys browser_action.default_title (i.e. the tooltip shown for the ABP icon on desktop, and the text shown in the menu on Firefox on Android) and short_name (not sure where this one is picked up, but it must have maximum 12 characters). So we still have to introduce a new string, and change buildtools to only use it for the name manifest key.
comment:18 Changed on 12/27/2018 at 11:36:56 AM by wspee
- Blocked By 7146 added
- Review URL(s) modified (diff)
- Summary changed from Change chrome extension name used in manifest for cws to Change manifest name for release builds
Thanks nice catch, changing the name everywhere wasn't the intention :). I have uploaded a new patch to change the string used for the name key in the manifest files for release builds only and updated #7146 accordingly. Please have another look.
We'll advance the buildtools dependency with the abp ui dependency update that lands #7146.
comment:19 Changed on 01/16/2019 at 04:05:39 PM by wspee
- Blocking 7219 added
comment:20 Changed on 01/17/2019 at 03:00:14 AM by abpbot
A commit referencing this issue has landed:
Issue 7145 - Change manifest name for release builds
comment:21 Changed on 01/17/2019 at 03:10:34 AM by sebastian
- Blocked By 7146 removed
This change itself doesn't depend on #7146, but the eventual dependency update is blocked by #7146 and this issue.
comment:22 Changed on 01/17/2019 at 03:10:42 AM by sebastian
- Resolution set to fixed
- Status changed from reopened to closed
comment:23 Changed on 01/17/2019 at 02:22:04 PM by wspee
- Description modified (diff)
Forgot to update the description after https://issues.adblockplus.org/ticket/7145#comment:15 updated it to reflect what has actually happened.
comment:24 Changed on 01/23/2019 at 12:25:47 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. New name appears in all browsers. Other title strings (Options page, icon hover etc.) are still "Adblock Plus" as expected.
ABP 3.4.2.2231
Chrome 71.0.3578.98 / Windows 10 (Latest)
Chrome 49.0.2623.75 / Windows 10 (Min supported)
Firefox 64.0.2 / Windows 10 (Latest)
Firefox 51.0 / Windows 10 (Min supported)
Opera 57.0.3098.76 / Windows 10 (Latest)
Opera 36.0.2130.65 / Windows 10 (Min supported)
(I'll update the status to codereview once this issue is ready)