Opened on 01/16/2019 at 04:05:39 PM
Closed on 01/17/2019 at 10:50:01 PM
Last modified on 01/23/2019 at 12:26:31 AM
#7219 closed change (fixed)
Update dependency adblockplusui to 8a52e194420f and buildtools to 6ba53f591579
| Reported by: | wspee | Assignee: | wspee |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, wspee, greiner | Blocked By: | #7145, #7146 |
| Blocking: | #7221 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/31 |
||
Description (last modified by wspee)
Background
For the upcoming minor release (3.4.3) we would like to include a change to the extension title (as shown in the add-on stores) (#7146). That also required a small change to our build scripts (#7145).
What to do
Update the adblockplusui dependency to hg:8a52e194420f git:453a0d9 and the buildtools dependency to hg:6ba53f591579 git:bad76f6.
Relevant included changes
| Ticket | Status | Resolution | Summary | Component | Owner |
|---|---|---|---|---|---|
| #7145 | closed | fixed | Change manifest name for release builds | Automation | |
| #7146 | closed | fixed | Add manifest name for release builds | User-Interface |
Hints for testers
This changes the extension's name, shown in the add-on stores and on the extension management page within the browser, for the release builds (only), to "Adblock Plus - free ad blocker". The browser action title, and any other occurrences of the name "Adblock Plus" in the extension's own UI should remain unchanged.
Note that this change has no effect on the development builds, hence can only tested by either manually creating a release build or after the release.
Note: The German translations purposely differ slightly because "Adblocker" has a higher search volume than the terms "ad blocker" as well as "Werbeblocker" in Germany.
Attachments (0)
Change History (16)
comment:2 Changed on 01/17/2019 at 04:03:30 AM by sebastian
- Cc sebastian wspee added
- Milestone set to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
comment:3 Changed on 01/17/2019 at 11:22:08 AM by greiner
- Blocking 7221 added
comment:6 Changed on 01/17/2019 at 02:07:23 PM by wspee
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 01/17/2019 at 02:11:52 PM by kzar
- Cc greiner added
- Description modified (diff)
- Priority changed from Unknown to P2
- Summary changed from Update dependency adblockplusui to TBA and buildtools to TBA to Update dependency adblockplusui to 8a52e194420f and buildtools to 6ba53f591579
comment:8 Changed on 01/17/2019 at 02:12:34 PM by kzar
- Owner set to wspee
comment:10 Changed on 01/17/2019 at 03:04:25 PM by kzar
- Description modified (diff)
- Ready set
comment:11 Changed on 01/17/2019 at 10:23:15 PM by sebastian
- Description modified (diff)
comment:12 Changed on 01/17/2019 at 10:24:05 PM by sebastian
- Description modified (diff)
comment:13 Changed on 01/17/2019 at 10:46:29 PM by abpbot
A commit referencing this issue has landed:
Issue 7219 - Updated adblockplusui to 8a52e194420f, buildtools to 6ba53f591579
comment:14 Changed on 01/17/2019 at 10:50:01 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:15 Changed on 01/18/2019 at 10:42:15 AM by wspee
- Description modified (diff)
comment:16 Changed on 01/23/2019 at 12:26:31 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. New name appears in all browsers. Other title strings (Options page, icon hover etc.) are still "Adblock Plus" as expected.
ABP 3.4.2.2231
Chrome 71.0.3578.98 / Windows 10 (Latest)
Chrome 49.0.2623.75 / Windows 10 (Min supported)
Firefox 64.0.2 / Windows 10 (Latest)
Firefox 51.0 / Windows 10 (Min supported)
Opera 57.0.3098.76 / Windows 10 (Latest)
Opera 36.0.2130.65 / Windows 10 (Min supported)
Please could you populate the "Hints for testers" section? Otherwise, this looks OK to me.